You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/08/23 15:05:00 UTC
Re: Review Request 61666: Added test to verify filtering of resource
reservations & allocations.
> On Aug. 21, 2017, 10:12 a.m., Alexander Rojas wrote:
> > src/tests/slave_authorization_tests.cpp
> > Lines 106 (patched)
> > <https://reviews.apache.org/r/61666/diff/1/?file=1798000#file1798000line106>
> >
> > _Only one default user…_
This comment was rewritten.
> On Aug. 21, 2017, 10:12 a.m., Alexander Rojas wrote:
> > src/tests/slave_authorization_tests.cpp
> > Lines 164 (patched)
> > <https://reviews.apache.org/r/61666/diff/1/?file=1798000#file1798000line164>
> >
> > I would rather have `acl->mutable_roles()->add_value(role_name)`
Fixed.
> On Aug. 21, 2017, 10:12 a.m., Alexander Rojas wrote:
> > src/tests/slave_authorization_tests.cpp
> > Lines 195 (patched)
> > <https://reviews.apache.org/r/61666/diff/1/?file=1798000#file1798000line195>
> >
> > can you give it a better name to this role, even _test-role_ would do, but if you look at api tests we use other things like _superhero_ or _muggle_.
I've introduced two roles *superhero* and *muggle*.
The test has been changed significantly.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61666/#review183321
-----------------------------------------------------------
On Aug. 15, 2017, 5:59 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61666/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2017, 5:59 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Greg Mann.
>
>
> Bugs: MESOS-7892
> https://issues.apache.org/jira/browse/MESOS-7892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch extends `SlaveAuthorizerTest.FilterStateEndpoint` test to
> check that agent's `/state` endpoint shows resource reservations and
> allocations based on the 'VIEW_ROLE' permissions of the principal
> doing the request.
>
>
> Diffs
> -----
>
> src/tests/slave_authorization_tests.cpp 536a8efda0cc1ba08285c379b01af6ec64a82117
>
>
> Diff: https://reviews.apache.org/r/61666/diff/2/
>
>
> Testing
> -------
>
> make check (mac os x, fedora 25)
>
>
> Thanks,
>
> Andrei Budnik
>
>