You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@click.apache.org by "Finn Bock (JIRA)" <ji...@apache.org> on 2009/10/22 21:42:59 UTC
[jira] Created: (CLK-586) Form javascript validation not called
when form is submitted with a SubmitLink
Form javascript validation not called when form is submitted with a SubmitLink
------------------------------------------------------------------------------
Key: CLK-586
URL: https://issues.apache.org/jira/browse/CLK-586
Project: Click
Issue Type: Bug
Components: extras
Affects Versions: 2.1.0 RC1
Reporter: Finn Bock
Priority: Minor
Calling form.submit() does not execute code on the onsubmit=".." event handler:
http://bytes.com/topic/javascript/answers/147399-submitting-form-onsubmit-validation
so the the validation code must be also be called on the onclick=".." event handler for the SubmitLink.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLK-586) Form javascript validation not called
when form is submitted with a SubmitLink
Posted by "Finn Bock (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Finn Bock updated CLK-586:
--------------------------
Attachment: form-example.zip
Example app.
Using the button the javascript prevents submitting to the server.
Using the SubmitLink the form is submitted even when the field is empty.
> Form javascript validation not called when form is submitted with a SubmitLink
> ------------------------------------------------------------------------------
>
> Key: CLK-586
> URL: https://issues.apache.org/jira/browse/CLK-586
> Project: Click
> Issue Type: Bug
> Components: extras
> Affects Versions: 2.1.0 RC1
> Reporter: Finn Bock
> Priority: Minor
> Attachments: form-example.zip
>
>
> Calling form.submit() does not execute code on the onsubmit=".." event handler:
> http://bytes.com/topic/javascript/answers/147399-submitting-form-onsubmit-validation
> so the the validation code must be also be called on the onclick=".." event handler for the SubmitLink.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CLK-586) Form javascript validation not called
when form is submitted with a SubmitLink
Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Schellink resolved CLK-586.
-------------------------------
Resolution: Fixed
> Form javascript validation not called when form is submitted with a SubmitLink
> ------------------------------------------------------------------------------
>
> Key: CLK-586
> URL: https://issues.apache.org/jira/browse/CLK-586
> Project: Click
> Issue Type: Bug
> Components: extras
> Affects Versions: 2.1.0 RC1
> Reporter: Finn Bock
> Assignee: Bob Schellink
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: form-example.zip, submitlink.patch
>
>
> Calling form.submit() does not execute code on the onsubmit=".." event handler:
> http://bytes.com/topic/javascript/answers/147399-submitting-form-onsubmit-validation
> so the the validation code must be also be called on the onclick=".." event handler for the SubmitLink.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLK-586) Form javascript validation not called
when form is submitted with a SubmitLink
Posted by "Bob Schellink (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bob Schellink updated CLK-586:
------------------------------
Fix Version/s: 2.1.0
Assignee: Bob Schellink
Great patch Finn. Its applied to trunk. Thanks.
> Form javascript validation not called when form is submitted with a SubmitLink
> ------------------------------------------------------------------------------
>
> Key: CLK-586
> URL: https://issues.apache.org/jira/browse/CLK-586
> Project: Click
> Issue Type: Bug
> Components: extras
> Affects Versions: 2.1.0 RC1
> Reporter: Finn Bock
> Assignee: Bob Schellink
> Priority: Minor
> Fix For: 2.1.0
>
> Attachments: form-example.zip, submitlink.patch
>
>
> Calling form.submit() does not execute code on the onsubmit=".." event handler:
> http://bytes.com/topic/javascript/answers/147399-submitting-form-onsubmit-validation
> so the the validation code must be also be called on the onclick=".." event handler for the SubmitLink.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CLK-586) Form javascript validation not called
when form is submitted with a SubmitLink
Posted by "Finn Bock (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLK-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Finn Bock updated CLK-586:
--------------------------
Attachment: submitlink.patch
A patch that add an explicit call to the on_form_submit() method before calling Click.submitLinkAction(..)
> Form javascript validation not called when form is submitted with a SubmitLink
> ------------------------------------------------------------------------------
>
> Key: CLK-586
> URL: https://issues.apache.org/jira/browse/CLK-586
> Project: Click
> Issue Type: Bug
> Components: extras
> Affects Versions: 2.1.0 RC1
> Reporter: Finn Bock
> Priority: Minor
> Attachments: form-example.zip, submitlink.patch
>
>
> Calling form.submit() does not execute code on the onsubmit=".." event handler:
> http://bytes.com/topic/javascript/answers/147399-submitting-form-onsubmit-validation
> so the the validation code must be also be called on the onclick=".." event handler for the SubmitLink.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.