You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by "Brock Noland (Commented) (JIRA)" <ji...@apache.org> on 2012/02/26 09:39:47 UTC
[jira] [Commented] (MRUNIT-46) Tests should use *Driver.new*Driver
factory methods for cleaner code
[ https://issues.apache.org/jira/browse/MRUNIT-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216669#comment-13216669 ]
Brock Noland commented on MRUNIT-46:
------------------------------------
Jim,
Excellent work! The only comment I have is the method added to o.a.h.mrunit.MapReduceDriver should also be added to o.a.h.mrunit.mapreduce.MapReduceDriver.
Thoughts?
Brock
> Tests should use *Driver.new*Driver factory methods for cleaner code
> --------------------------------------------------------------------
>
> Key: MRUNIT-46
> URL: https://issues.apache.org/jira/browse/MRUNIT-46
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-46.patch
>
>
> Our tests should use the new MapDriver.new* factory methods as it removes a lot of complexity.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira