[GitHub] [airflow] ToxaZ edited a comment on issue #5688: [AIRFLOW-5073] Treat NULL as fail in SQL sensor

[GitBox <gi...@apache.org>]

ToxaZ edited a comment on issue #5688: [AIRFLOW-5073] Treat NULL as fail in SQL sensor
URL: https://github.com/apache/airflow/pull/5688#issuecomment-522670648
 
 
   I strongly agree with this kind of fix:
   > Having looked into this more, if anything I'd actually vote do _not_ add `allow_null` parameter; just add `None` to the "Not done" list, i.e. as though this were a bugfix. The sensor is already confusing enough and if someone really needs None to mean "done" they can add a success callable e.g. `lambda x: str(x) == 'None'`
   
   Although I've changed default behavior to the legacy one to make it shipped to near releases.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services