[PATCH] tiny improvement to testsuite

[Kamesh Jayachandran <ka...@collab.net>]

Hi All,
While analysing few of the test failures I came across this tiny 
improvement to subversion/tests/cmdline/svntest/actions.py

With regards
Kamesh Jayachandran

[[[
Patch by: Kamesh Jayachandran <ka...@collab.net>

* subversion/tests/cmdline/svntest/actions.py
  (match_or_fail):
  From the docstring of match_or_fail it seems that it succeeds for match on
  atleast one line. In that case on first match itself 'for' loop can be 
broken,
  rather than matching lines even after the successful match.
]]]

Re: [PATCH] tiny improvement to testsuite

[Kamesh Jayachandran <ka...@collab.net>]

Thanks Julian.
For me learning from this is 'for-else'.
I was confused to see the 'else' in solitude and thought that it could 
be a typo or whatever.
Later when ran the testsuite I could see it is working and finally come 
to know about the existence of for-else and its nuances.

Thanks
With regards
Kamesh Jayachandran
Julian Foad wrote:
> Kamesh Jayachandran wrote:
>> Hi All,
>> While analysing few of the test failures I came across this tiny 
>> improvement to subversion/tests/cmdline/svntest/actions.py
>
> Thanks. I committed a change that does this (breaks out of the loop 
> early) and also eliminates the temporary variable, using "else" 
> instead. r18372.
>
> - Julian
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] tiny improvement to testsuite

[Julian Foad <ju...@btopenworld.com>]

Kamesh Jayachandran wrote:
> Hi All,
> While analysing few of the test failures I came across this tiny 
> improvement to subversion/tests/cmdline/svntest/actions.py

Thanks.  I committed a change that does this (breaks out of the loop early) and 
also eliminates the temporary variable, using "else" instead.  r18372.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org