You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by YorkShen <gi...@git.apache.org> on 2017/06/05 07:02:04 UTC
[GitHub] incubator-weex pull request #418: * [android] Support rotateX and rotateY, o...
GitHub user YorkShen opened a pull request:
https://github.com/apache/incubator-weex/pull/418
* [android] Support rotateX and rotateY, optimize animation as well.
* [Use LayoutParamsProperty instead of DimensionUpdateListener to achieve height/width animation.](http://dotwe.org/vue/c7a70462a136b61e11ab37f384862003)
* [Support rotateX and rotateY.](http://dotwe.org/vue/b13927aa309b5402bdf49bf9f546f7d8)
* Stop remove transform and transform-origin from WXStyle in UpdateStyleAction.
* Stop execute animation callback if corresponding WXInstance is destroyed when animation finished.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YorkShen/incubator-weex android-feature-animation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/418.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #418
----
commit 061f884934944a257b399826d9b3dedcc2042281
Author: YorkShen <sh...@gmail.com>
Date: 2017-06-05T06:59:31Z
* [android] Support rotateX and rotateY, optimize animation as well.
* [Use LayoutParamsProperty instead of DimensionUpdateListener to achieve height/width animation.](http://dotwe.org/vue/c7a70462a136b61e11ab37f384862003)
* [Support rotateX and rotateY.](http://dotwe.org/vue/b13927aa309b5402bdf49bf9f546f7d8).
* Stop remove transform and transform-origin from WXStyle in UpdateStyleAction.
* Stop execute animation callback if corresponding WXInstance is destroyed when animation finished.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #418: * [android] Support rotateX and rotateY, o...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/418#discussion_r120791608
--- Diff: android/sdk/src/main/java/com/taobao/weex/ui/animation/HeightProperty.java ---
@@ -0,0 +1,17 @@
+package com.taobao.weex.ui.animation;
--- End diff --
src header
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #418: * [android] Support rotateX and rotateY, o...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/418#discussion_r120791846
--- Diff: android/sdk/src/main/java/com/taobao/weex/ui/animation/WidthProperty.java ---
@@ -0,0 +1,17 @@
+package com.taobao.weex.ui.animation;
--- End diff --
src header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #418: * [android] Support rotateX and rotateY, optimize...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/418
Pls create JIRA issue before you merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #418: * [android] Support rotateX and rotateY, o...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/418#discussion_r120791550
--- Diff: android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java ---
@@ -676,6 +674,9 @@ protected boolean setProperty(String key, Object param) {
boolean isHidden = WXUtils.getBoolean(param,false);
setAriaHidden(isHidden);
return true;
+// case Constants.Name.PERSPECTIVE:
--- End diff --
Remove these lins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #418: * [android] Support rotateX and rotateY, o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/418
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #418: * [android] Support rotateX and rotateY, optimize...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/418
https://issues.apache.org/jira/browse/WEEX-38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #418: * [android] Support rotateX and rotateY, o...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/418#discussion_r120791696
--- Diff: android/sdk/src/main/java/com/taobao/weex/common/Constants.java ---
@@ -174,6 +174,7 @@
String NORMAL = "normal";
String ARIA_LABEL = "ariaLabel";
String ARIA_HIDDEN = "ariaHidden";
+ //String PERSPECTIVE = "perspective";
--- End diff --
Remove commented line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #418: * [android] Support rotateX and rotateY, optimize...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/418
<!--
1 failure: Running your Dang...
0 warning:
1 markdown notices
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>Running your Dangerfile has Failed</td>
</tr>
</tbody>
</table>
## Danger has errored
Error: TypeError
```sh
TypeError: diff.match is not a function
at Object.<anonymous> (dangerfile.js:109:24)
at Runtime._execModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:447:13)
at Runtime.requireModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:295:14)
at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:136:33
at ensureCleanDangerfile (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:176:5)
at Object.<anonymous> (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:135:21)
at step (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:32:23)
at Object.next (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:13:53)
at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:7:71
at __awaiter (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:3:12)
```
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #418: * [android] Support rotateX and rotateY, o...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/418#discussion_r120791623
--- Diff: android/sdk/src/main/java/com/taobao/weex/ui/animation/LayoutParamsProperty.java ---
@@ -0,0 +1,46 @@
+package com.taobao.weex.ui.animation;
--- End diff --
src header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---