You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:55:48 UTC
[GitHub] [servicecomb-service-center] xzccfzy commented on a change in pull request #733: [SCB-2094] change old api, use datasource api
xzccfzy commented on a change in pull request #733:
URL: https://github.com/apache/servicecomb-service-center/pull/733#discussion_r515762647
##########
File path: server/service/schema_test.go
##########
@@ -909,16 +909,6 @@ var _ = Describe("'Schema' service", func() {
})
Expect(err).To(BeNil())
Expect(respModifySchemas.Response.GetCode()).To(Equal(scerr.ErrUndefinedSchemaID))
-
- By("schema edit allowed, add a schema with new schemaId should success")
-
- localServiceResource = service.NewMicroServiceService(true, instanceResource)
- respModifySchemas, err = localServiceResource.ModifySchemas(getContext(), &pb.ModifySchemasRequest{
Review comment:
这里和@little-cui 拉会对过了。改为新的api之后无法修改schemaEditable参数的指，删掉的ut在etcd里面的ut有。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org