You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/08 15:19:14 UTC
[GitHub] [incubator-kvrocks] tanruixiang opened a new pull request, #838: fix missing golangci-lint in help
tanruixiang opened a new pull request, #838:
URL: https://github.com/apache/incubator-kvrocks/pull/838
The `golangci-lint` is missing in`x.py -h`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #838: fix missing golangci-lint in help
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #838:
URL: https://github.com/apache/incubator-kvrocks/pull/838#discussion_r966118275
##########
x.py:
##########
@@ -257,8 +257,8 @@ def test_go(dir: str, rest: List[str]) -> None:
parser_check = subparsers.add_parser(
'check',
- description="Check code with cpplint or cppcheck",
- help="Check code with cpplint or cppcheck")
+ description="Check code with cpplint or cppcheck or golangci-lint",
+ help="Check code with cpplint or cppcheck or golangci-lint")
Review Comment:
```suggestion
description="Check or lint source code",
help="Check or lint source code")
```
I think it's time to stop enumerating candidates, they should already show up in the help message:
```
usage: x.py check [-h] {cpplint,cppcheck,golangci-lint} ...
Check code with cpplint or cppcheck
positional arguments:
{cpplint,cppcheck,golangci-lint}
cpplint Lint code with cpplint
(https://github.com/cpplint/cpplint)
cppcheck Check code with cppcheck
(https://github.com/danmar/cppcheck)
golangci-lint Check code with golangci-lint (https://golangci-
lint.run/)
options:
-h, --help show this help message and exit
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #838: fix missing golangci-lint in help
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #838:
URL: https://github.com/apache/incubator-kvrocks/pull/838#discussion_r966118275
##########
x.py:
##########
@@ -257,8 +257,8 @@ def test_go(dir: str, rest: List[str]) -> None:
parser_check = subparsers.add_parser(
'check',
- description="Check code with cpplint or cppcheck",
- help="Check code with cpplint or cppcheck")
+ description="Check code with cpplint or cppcheck or golangci-lint",
+ help="Check code with cpplint or cppcheck or golangci-lint")
Review Comment:
```suggestion
description="Check or lint source code",
help="Check or lint source code")
```
I think it's time to stop enumerating candidates, they should already show up in the help message:
```
./x.py check
usage: x.py check [-h] {cpplint,cppcheck} ...
Check code with cpplint or cppcheck
positional arguments:
{cpplint,cppcheck}
cpplint Lint code with cpplint
(https://github.com/cpplint/cpplint)
cppcheck Check code with cppcheck
(https://github.com/danmar/cppcheck)
options:
-h, --help show this help message and exit
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tanruixiang commented on a diff in pull request #838: fix missing golangci-lint in help
Posted by GitBox <gi...@apache.org>.
tanruixiang commented on code in PR #838:
URL: https://github.com/apache/incubator-kvrocks/pull/838#discussion_r966127118
##########
x.py:
##########
@@ -257,8 +257,8 @@ def test_go(dir: str, rest: List[str]) -> None:
parser_check = subparsers.add_parser(
'check',
- description="Check code with cpplint or cppcheck",
- help="Check code with cpplint or cppcheck")
+ description="Check code with cpplint or cppcheck or golangci-lint",
+ help="Check code with cpplint or cppcheck or golangci-lint")
Review Comment:
Can't agree more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #838: chore: better help info for x.py check -h
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #838:
URL: https://github.com/apache/incubator-kvrocks/pull/838#issuecomment-1241004845
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #838: chore: better help info for x.py check -h
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #838:
URL: https://github.com/apache/incubator-kvrocks/pull/838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org