You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mindlesscloud (via GitHub)" <gi...@apache.org> on 2023/02/06 14:24:17 UTC

[GitHub] [incubator-devlake] mindlesscloud opened a new pull request, #4337: Fix jira 400 error on collecting account

mindlesscloud opened a new pull request, #4337:
URL: https://github.com/apache/incubator-devlake/pull/4337

   ### Summary
   Fix the bug reported in #4302, which is triggered by requesting the `user` API `/rest/api/2/user` with an empty `accountId` parameter. This PR includes the following modification:
   - save the `account` only if the accountId is not empty
   - make sure the `accountId` is not empty when sending the HTTP request
   - add e2e test
   
   ### Does this close any open issues?
   Closes #4302 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] abeizn merged pull request #4337: Fix jira 400 error on collecting account

Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn merged PR #4337:
URL: https://github.com/apache/incubator-devlake/pull/4337


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #4337: Fix jira 400 error on collecting account

Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on code in PR #4337:
URL: https://github.com/apache/incubator-devlake/pull/4337#discussion_r1098100642


##########
backend/plugins/jira/tasks/issue_changelog_extractor.go:
##########
@@ -69,12 +69,17 @@ func ExtractIssueChangelogs(taskCtx plugin.SubTaskContext) errors.Error {
 			// this is crucial for incremental update
 			cl.IssueUpdated = &input.UpdateTime
 			// collect changelog / user inforation
-			result = append(result, cl, user)
+			result = append(result, cl)
+			if user != nil {

Review Comment:
   Is there still need user.AccountId != ""？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] mindlesscloud commented on a diff in pull request #4337: Fix jira 400 error on collecting account

Posted by "mindlesscloud (via GitHub)" <gi...@apache.org>.
mindlesscloud commented on code in PR #4337:
URL: https://github.com/apache/incubator-devlake/pull/4337#discussion_r1098105900


##########
backend/plugins/jira/tasks/issue_changelog_extractor.go:
##########
@@ -69,12 +69,17 @@ func ExtractIssueChangelogs(taskCtx plugin.SubTaskContext) errors.Error {
 			// this is crucial for incremental update
 			cl.IssueUpdated = &input.UpdateTime
 			// collect changelog / user inforation
-			result = append(result, cl, user)
+			result = append(result, cl)
+			if user != nil {

Review Comment:
   If the `user` is not nil, the struct field `AccountId` will not be empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org