You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Karen Miller <km...@pivotal.io> on 2016/12/05 18:57:52 UTC
Review Request 54385: GEODE-2180 Autoreconnect with API configuration
detail
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54385/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Dave Barnes, Joey McAllister, and Kirk Lund.
Repository: geode
Description
-------
Autoreconnect assumes valid XML configuration (from the
default use of the cluster config svc). That doesn't
work if the cache is configured using API calls. So,
document this, and suggest disabling either default use
of autoreconnect or default use of the cluster configuration
service.
Diffs
-----
geode-docs/managing/autoreconnect/member-reconnect.html.md.erb 916d301a523f052efe83c33fa318898bc75273e5
Diff: https://reviews.apache.org/r/54385/diff/
Testing
-------
gradle rat check passes
Book builds with no broken links.
Thanks,
Karen Miller
Re: Review Request 54385: GEODE-2180 Autoreconnect with API
configuration detail
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54385/#review158072
-----------------------------------------------------------
geode-docs/managing/autoreconnect/member-reconnect.html.md.erb (line 31)
<https://reviews.apache.org/r/54385/#comment228752>
receives a new _distributed member id_
- Bruce Schuchardt
On Dec. 5, 2016, 6:57 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54385/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 6:57 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Dave Barnes, Joey McAllister, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Autoreconnect assumes valid XML configuration (from the
> default use of the cluster config svc). That doesn't
> work if the cache is configured using API calls. So,
> document this, and suggest disabling either default use
> of autoreconnect or default use of the cluster configuration
> service.
>
>
> Diffs
> -----
>
> geode-docs/managing/autoreconnect/member-reconnect.html.md.erb 916d301a523f052efe83c33fa318898bc75273e5
>
> Diff: https://reviews.apache.org/r/54385/diff/
>
>
> Testing
> -------
>
> gradle rat check passes
>
> Book builds with no broken links.
>
>
> Thanks,
>
> Karen Miller
>
>
Re: Review Request 54385: GEODE-2180 Autoreconnect with API
configuration detail
Posted by Joey McAllister <jm...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54385/#review158041
-----------------------------------------------------------
Fix it, then Ship it!
Fix, then ship!
geode-docs/managing/autoreconnect/member-reconnect.html.md.erb (line 27)
<https://reviews.apache.org/r/54385/#comment228712>
This seems a little awkward. Perhaps:
> "and, by default, automatically restarts into"
geode-docs/managing/autoreconnect/member-reconnect.html.md.erb (line 46)
<https://reviews.apache.org/r/54385/#comment228715>
by setting the property to
geode-docs/managing/autoreconnect/member-reconnect.html.md.erb (line 52)
<https://reviews.apache.org/r/54385/#comment228716>
setting the property to
- Joey McAllister
On Dec. 5, 2016, 6:57 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54385/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 6:57 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Dave Barnes, Joey McAllister, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Autoreconnect assumes valid XML configuration (from the
> default use of the cluster config svc). That doesn't
> work if the cache is configured using API calls. So,
> document this, and suggest disabling either default use
> of autoreconnect or default use of the cluster configuration
> service.
>
>
> Diffs
> -----
>
> geode-docs/managing/autoreconnect/member-reconnect.html.md.erb 916d301a523f052efe83c33fa318898bc75273e5
>
> Diff: https://reviews.apache.org/r/54385/diff/
>
>
> Testing
> -------
>
> gradle rat check passes
>
> Book builds with no broken links.
>
>
> Thanks,
>
> Karen Miller
>
>
Re: Review Request 54385: GEODE-2180 Autoreconnect with API
configuration detail
Posted by Dave Barnes <db...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54385/#review158048
-----------------------------------------------------------
Ship it!
Incorporate Joey's edits and ship it!
- Dave Barnes
On Dec. 5, 2016, 6:57 p.m., Karen Miller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54385/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 6:57 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Dave Barnes, Joey McAllister, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Autoreconnect assumes valid XML configuration (from the
> default use of the cluster config svc). That doesn't
> work if the cache is configured using API calls. So,
> document this, and suggest disabling either default use
> of autoreconnect or default use of the cluster configuration
> service.
>
>
> Diffs
> -----
>
> geode-docs/managing/autoreconnect/member-reconnect.html.md.erb 916d301a523f052efe83c33fa318898bc75273e5
>
> Diff: https://reviews.apache.org/r/54385/diff/
>
>
> Testing
> -------
>
> gradle rat check passes
>
> Book builds with no broken links.
>
>
> Thanks,
>
> Karen Miller
>
>