[GitHub] [incubator-superset] nytai commented on a change in pull request #12121: fix(report): fix last_eval_dttm sort and more tests

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #12121:
URL: https://github.com/apache/incubator-superset/pull/12121#discussion_r546034387



##########
File path: superset/app.py
##########
@@ -429,8 +430,19 @@ def init_views(self) -> None:
             )
             appbuilder.add_view_no_menu(AlertLogModelView)
             appbuilder.add_view_no_menu(AlertObservationModelView)
-            if feature_flag_manager.is_feature_enabled("SIP_34_ALERTS_UI"):
-                appbuilder.add_view_no_menu(AlertReportModelView)
+
+        if feature_flag_manager.is_feature_enabled(
+            "ALERT_REPORTS"
+        ) and feature_flag_manager.is_feature_enabled("SIP_34_ALERTS_UI"):

Review comment:
       we recently removed `SIP_34_ALERTS_UI`, `ALERT_REPORTS` should be the only one going forward.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org