[jira] [Commented] (FLINK-4644) Deprecate "flink.base.dir.path" from ConfigConstants

["Stephan Ewen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507579#comment-15507579 ] 

Stephan Ewen commented on FLINK-4644:
-------------------------------------

It was initially used by the web frontend, IIRC.

+1 for deprecating it.

> Deprecate "flink.base.dir.path" from ConfigConstants
> ----------------------------------------------------
>
>                 Key: FLINK-4644
>                 URL: https://issues.apache.org/jira/browse/FLINK-4644
>             Project: Flink
>          Issue Type: Wish
>    Affects Versions: 1.2.0
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> Flink's configuration entry "flink.base.dir.path" is not documented anywhere but present in {{ConfigConstants}}. It is set in the JobManager but it is not accessed anywhere in the code.
> I propose to deprecate the entry from ConfigConstants:
> public static final String FLINK_BASE_DIR_PATH_KEY = "flink.base.dir.path";
> I think this entry can only possibly be abused by users to write into the Flink base dir or rely on some structure of the directory (which is different for standalone, yarn/mesos). The only way i can see such a variable being useful if it is present in the form of an environment variable to make it available to other systems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)