You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/18 06:40:34 UTC
[GitHub] [iceberg] nastra opened a new pull request, #5566: Core: Commit empty op in CatalogHandlers
nastra opened a new pull request, #5566:
URL: https://github.com/apache/iceberg/pull/5566
This is related to #5536 and it probably makes sense to let
`TableOperations` detect that metadata hasn't changed rather than not
calling commit on the operation itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra closed pull request #5566: Core: Commit empty op in CatalogHandlers
Posted by GitBox <gi...@apache.org>.
nastra closed pull request #5566: Core: Commit empty op in CatalogHandlers
URL: https://github.com/apache/iceberg/pull/5566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #5566: Core: Commit empty op in CatalogHandlers
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5566:
URL: https://github.com/apache/iceberg/pull/5566#issuecomment-1219848701
I'm not sure that this makes sense for catalog handlers. It makes sense in operations because the operation may be included in a transaction and need to commit. But that commit will produce the same metadata and the `TableOperations` will skip making a change in the underlying catalog.
Here, the situation is that a REST service receives a request to update a table with no changes. I think in that case it's perfectly fine to return early and send back 200.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org