You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Ignacio Mulas <no...@github.com> on 2013/09/04 15:53:54 UTC
[jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
This code adds the possibility to configure Jclouds (keystone module) to use the internal urls services' endpoints.
You can merge this Pull Request by running:
git pull https://github.com/sallum/jclouds master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/142
-- Commit Summary --
* [JCLOUDS-263] Usage of internalURL services' endpoints
-- File Changes --
A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/functions/EndpointToSupplierInternalURI.java (26)
A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/functions/InternalURL.java (44)
A apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/functions/InternalURLTest.java (40)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/142.patch
https://github.com/jclouds/jclouds/pull/142.diff
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #286](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/286/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25877811
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Ignacio Mulas <no...@github.com>.
What exactly do you want to include into the live test? It can be applied to several services so how do you propose to test it? :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-23866572
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Ignacio Mulas <no...@github.com>.
Hello! I corrected the code according to your comments.Thanks @everett-toews and @demobox!
It should be properly working now (I have just run it on my openstack instance). @everett-toews please give it try if you have some spare time and let me know if it got better now :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-29802927
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #454](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/454/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-30216091
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Everett Toews <no...@github.com>.
That's okay if you need to create a new, separate live test. I'm okay with you just asserting that it's a valid URL. I'm not too concerned about the differences. I just need to know that this thing works in a live environment other than your local environment.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-23891000
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #455](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/455/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-30217678
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #856](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/856/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28399712
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #392](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/392/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28395798
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #893](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/893/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-29803193
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Everett Toews <no...@github.com>.
Something simple will be fine. How about just getting the internalURL of the Nova endpoint and asserting that it's a valid URL. To make sure the test is as generic as possible you would have to call NovaApi.getConfiguredZones() to get a region you could use in the test. I think it could reasonably go in ServerApiLiveTest.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-23874169
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
> +/**
> + * Select internal URL endpoints services
> + *
> + * @author Ignacio Mulas
> + */
> +@Singleton
> +public class InternalURL implements EndpointToSupplierInternalURI {
> + @Override
> + public Supplier<URI> apply(Endpoint input) {
> + return Suppliers.ofInstance(input.getInternalURL());
> + }
> +
> + @Override
> + public String toString() {
> + return "supplyInternalURL()";
> + }
Formatting is off here, by the way
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142/files#r7806105
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Ignacio Mulas <no...@github.com>.
Thanks for your comments @everett-toews and @demobox! Unfortunately I cannot spend too much time on this now, but I definitely look into them during next week and come back to you! :)
The idea behind this change is to give the jclouds user a way of selecting the internalUrl from the services catalog returned by keystone. At the moment Jclouds is configured to read the endpoint value from the publicUrl and return the internal only if the public is null. This change allow you to override that configuration and use the internalUrl instead. It is slightly different from the EndpointToSupplierAdminURI as this module is needed by keystone to work properly.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28998346
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Everett Toews <no...@github.com>.
@sallum This is a good and necessary addition to jclouds. I really want to see this get in. That said I've hit a problem.
I've been live testing this but I can't make it fail, which I think points to a problem. I'm using the following command to live test this against a temp instance of DevStack I have running.
cd apis/openstack-nova
mvn clean test -Plive -Dtest.openstack-nova.endpoint=http://166.78.236.107:5000/v2.0/ -Dtest.openstack-nova.identity=demo:demo -Dtest.openstack-nova.credential=devstack -Dtest=InternalURLLiveTest
However, I've changed my internalURL for nova to an IP that doesn't exist. So the test should fail with a host not found exception or timeout. Here's the nova entry in my service catalog. You can see the internalURL is different from the publicURL.
{
"name": "nova",
"type": "compute",
"endpoints_links": [],
"endpoints": [
{
"publicURL": "http://166.78.236.107:8774/v2/134e0fd0c239484dbfe3fdcb5211d4dc",
"id": "39e4d2edc69140ae9aa742d7fd69b16b",
"internalURL": "http://not.even.an.ip/v2/134e0fd0c239484dbfe3fdcb5211d4dc",
"region": "RegionOne",
"adminURL": "http://166.78.236.107:8774/v2/134e0fd0c239484dbfe3fdcb5211d4dc"
}
]
},
When I look at the log generated in `target/test-data/jclouds-wire.log` I can see that the call to `novaApi.getServerApiForZone(zone).list().concat().toList()` in `InternalURLLiveTest` goes to the publicURL `http://166.78.236.107:8774/v2/134e0fd0c239484dbfe3fdcb5211d4dc/servers` and _not_ the internalURL `http://not.even.an.ip/v2/134e0fd0c239484dbfe3fdcb5211d4dc/servers`
Also, if I run the test in my IDE and set breakpoints in https://github.com/sallum/jclouds/blob/555a5377a48204805b6db9d607e899fcde6abbff/apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/functions/InternalURL.java#L37 and https://github.com/sallum/jclouds/blob/555a5377a48204805b6db9d607e899fcde6abbff/apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/functions/InternalURLLiveTest.java#L45 the run stops in InternalUrlModule.configure() but not in InternalURL.apply().
Looking at the work done for AdminURL in the `org.jclouds.openstack.keystone.v2_0.suppliers` I suspect there's more Guice config to be done before the internalURL can be used.
Can you run your live test against my DevStack instance? Are you seeing similar behaviour? Am I missing something?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28924788
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.jclouds.openstack.keystone.v2_0.functions;
> +
> +import com.google.inject.ImplementedBy;
> +
> +/**
> + * @author Ignacio Mulas
> + */
> +@ImplementedBy(InternalURL.class)
> +public interface EndpointToSupplierInternalURI extends EndpointToSupplierURI {
We're creating this new interface, but where is it actually _used_? If we're just trying to give a "hint" to Guice to use a different implementation class, I'm not sure this is the way to do it.
Am I understanding correctly that what we're trying to do is change/override the binding to `EndpointToSupplierURI`, but not to make this change by default - rather, to allow you to supply a custom module to do this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142/files#r7806382
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #684](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/684/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-30215943
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #855](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/855/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28395833
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Jamal CHAQOURI <no...@github.com>.
I found the solution, thanks to jclouds IRC. I replaced "cloudfiles-uk" by the new provider "rackspace-cloudfiles-uk" which is uses keystone v2, then it's possible to use InternalUrlModule. If you're forced to be in keystone v1, you'll have to develop your own InternalUrlModule for this version.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-49026689
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
> jclouds » jclouds #486 FAILURE
BuildHive is [still complaining](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/486/org.apache.jclouds.api$openstack-nova/console), but I don't know whether that's something to do with a stale workspace or something, since DEV@cloud seems [happier now](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/287/org.apache.jclouds.api$openstack-nova/console).
Let's proceed with the review and revisit this if BuildHive keeps failing.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25880687
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Everett Toews <no...@github.com>.
This is the part that wasn't working for me. I ran the live test with the mvn command as above and I was still getting the publicURL back.
On Nov 21, 2013, at 11:38 AM, Ignacio Mulas wrote:
Exactly! In that sense it would be easy to modify that default behaviour just binding the module in your client application
—
Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/142#issuecomment-29005305>.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-29019288
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Jamal CHAQOURI <no...@github.com>.
Hi,
I'm using jclouds BlobStore API with Rackspace as provider. The InternalUrlModule is only available for keystone v2_0 not for v1_1. That differs from PublicURLOrInternalIfNull, which has two different classes. Is this done on purpose? or, can i do a PR to make InternalUrlModule available for keystone v1_1 ?
Thanks for help
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-48971207
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Everett Toews <no...@github.com>.
> +import com.google.inject.AbstractModule;
> +import com.google.inject.Module;
> +import com.google.inject.Singleton;
> +
> +/**
> + * Simple live test to check the correct loading of the internal endpoint
> + * services.
> + *
> + * @author Ignacio Mulas
> + *
> + */
> +@Test(groups = "live", testName = "InternalURLLiveTest")
> +public class InternalURLLiveTest extends BaseNovaApiLiveTest {
> +
> + @Singleton
> + class InternalUrlModule extends AbstractModule {
This is a very useful class for all OpenStack APIs that many will want to reuse.
Can you please move it to jclouds/apis/openstack-keystone/src/main/java/org/jclouds/openstack/v2_0/config (a package that doesn't exist yet)?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142/files#r8221312
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
@everett-toews: Any more comments about this one..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-27155441
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Ignacio Mulas <no...@github.com>.
Exactly! In that sense it would be easy to modify that default behaviour just binding the module in your client application
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-29005305
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #747](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/747/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25877356
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #287](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/287/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25879505
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Everett Toews <no...@github.com>.
Can you please create a live test for this that I could run against a DevStack deployment?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-23792756
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Everett Toews <no...@github.com>.
+1
Nice work @sallum. Thanks for sticking with us!
Merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-30341813
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #486](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/486/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25879332
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
> + */
> +@Test(groups = "live", testName = "InternalURLLiveTest")
> +public class InternalURLLiveTest extends BaseNovaApiLiveTest {
> +
> + @Singleton
> + class InternalUrlModule extends AbstractModule {
> + @Override
> + protected void configure() {
> + bind(EndpointToSupplierInternalURI.class).to(InternalURL.class);
> + }
> + }
> +
> + @Test(description = "InternalUrl service endpoints loader")
> + public void testGetInternalUrlServiceEndpoint() throws Exception {
> + Iterable<Module> modules = ImmutableSet.<Module> of(getLoggingModule(), new InternalUrlModule());
> + NovaApi novaApi = ContextBuilder.newBuilder(provider).modules(modules).overrides(setupProperties()).buildApi(NovaApi.class);
What happens if, rather than creating our own API here, we override [`setupModules`](https://github.com/jclouds/jclouds/blob/master/core/src/test/java/org/jclouds/apis/BaseApiLiveTest.java#L87) and then use the [`api`](https://github.com/jclouds/jclouds/blob/master/core/src/test/java/org/jclouds/apis/BaseApiLiveTest.java#L49) that the test harness creates?
I'm not sure this will initially change much, but then at least we're using the "standard" context setup for live tests?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142/files#r7806294
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #385](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/385/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28299091
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #603](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/603/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28299105
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
Looks like a [license violation](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/286/console):
```
Stack trace :
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.rat:apache-rat-plugin:0.9:check (default) on project openstack-nova: Too many files with unapproved license: 1 See RAT report in: /scratch/jenkins/workspace/jclouds-pull-requests/apis/openstack-nova/target/rat.txt
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25878183
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #393](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/393/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28399677
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #749](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/749/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25879514
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #848](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/848/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28299086
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #285](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/285/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25877357
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Ignacio Mulas <no...@github.com>.
One problem I see with that is that I cannot use the same api than the other test methods, I have to create a new Api loading a pre-created internal class InternalUrlModule (extends AbstractModule) and then execute a nova command through this Api. Is this ok? Or should we place it somewhere else?
Another question I have is how do you ensure that the endpoint taken is the internal (by default adminUrl, publicUrl and InternalUrl have the same value)? Only if you change the keystone services endpoints to different values on your devstack instance you can be sure that you are taking the right one, am I wrong here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-23879028
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
> Create a new PR to port #201 ported to master, merge that one, and rebase and start working again in this one.
I would prefer this one, if possible?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28403709
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Ignacio Mulas <no...@github.com>.
You can run the test with the maven command:
clean test -Plive -Dtest.openstack-nova.identity=demo:demo -Dtest.openstack-nova.credential=openstack -Dtest.openstack-nova.endpoint=http://192.168.100.10:5000/v2.0 -Dtest=InternalURLLiveTest
Nova endpoint:
{"adminURL": "http://192.168.100.10:8774/v2/0faa343926f147209a3f60c10b84ab03", "region": "regionOne", "internalURL": "http://10.0.200.1:8774/v2/0faa343926f147209a3f60c10b84ab03", "id": "88e6ad9bb61d451f8512de71f73d8c32", "publicURL": "http://192.168.100.10:8774/v2/0faa343926f147209a3f60c10b84ab03"}], "endpoints_links": [], "type": "compute", "name": "nova"}
>From Wirelogs:
2013-12-07 11:48:30,419 DEBUG [jclouds.headers] [pool-1-thread-1] >> GET http://10.0.200.1:8774/v2/0faa343926f147209a3f60c10b84ab03/servers HTTP/1.1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-30052578
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #198](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/198/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-23794894
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Ignacio Mulas <no...@github.com>.
Thanks for the reviews @everett-toews and @demobox! I updated the code with your comments :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-30214550
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Ignacio Mulas <no...@github.com>.
Ups! I will correct it push it back with the license
Thanks for the comment :)
2013/10/8 Andrew Phillips <no...@github.com>
> Looks like a license violation<https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/286/console>
> :
>
> Stack trace :
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.rat:apache-rat-plugin:0.9:check (default) on project openstack-nova: Too many files with unapproved license: 1 See RAT report in: /scratch/jenkins/workspace/jclouds-pull-requests/apis/openstack-nova/target/rat.txt
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/142#issuecomment-25878183>
> .
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25878430
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
@everett-toews or @zack-shoylev: Is this good to go from your perspective?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-30169369
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Ignasi Barrera <no...@github.com>.
This PR seems to have become https://github.com/jclouds/jclouds/pull/201 ported to master.
@demobox @everett-toews @sallum, how do you prefer to proceed?
* Amend the commit message and the PR description to reflect the real issue being fixed, merge this PR, and then open a new one for the "internalURL" thing.
* Create a new PR to port https://github.com/jclouds/jclouds/pull/201 ported to master, merge that one, and rebase and start working again in this one.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28402667
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
Looks good to me. @everett-toews: OK for you?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-30236293
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #659](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/659/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-23794903
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #610](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/610/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28402331
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
Minor note: a couple of the files use two-space and/or tab rather than 3-space indents
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28932369
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
@sallum: could you move 4d309dc into its own PR so that we can merge that independently of this?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-28396938
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #916](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/916/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-30216056
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #430](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/430/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-29803171
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #917](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/917/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-30217741
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
> jclouds » jclouds #487 SUCCESS
Even better ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25882002
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Everett Toews <no...@github.com>.
@demobox @sallum I got my the test to fail so everything is looking good! :D
Which is to say, I get the error
HttpResponseException: not.even.an.ip connecting to GET http://not.even.an.ip/v2/134e0fd0c239484dbfe3fdcb5211d4dc/servers
When I ran the test against my DevStack with the internalURL set to not.even.an.ip so I know it's using the internalURL. Just that one last comment about moving the InternalUrlModule class and we're good to go!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-30196425
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #485](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/485/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25878107
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
> The idea behind this change is to give the jclouds user a way of selecting the internalUrl from the services catalog
> returned by keystone.
Ah, so you would use it as demonstrated in the test: create a module to override the standard EndpointToSupplierURI binding and pass that module to the context builder when creating your context?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-29004111
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #748](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/748/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-25877809
Re: [jclouds] [JCLOUDS-263] Usage of internalURL services' endpoints
(#142)
Posted by Andrew Phillips <no...@github.com>.
> It should be properly working now (I have just run it on my openstack instance).
Great to hear! Could you post the sample code you used to test this somewhere (in a comment, Gist, Pastie etc.)?
Thanks, @sallum!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/142#issuecomment-29815338