You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/08/04 14:56:15 UTC

[GitHub] [servicecomb-service-center] Sphairis opened a new pull request #1126: set a complete token

Sphairis opened a new pull request #1126:
URL: https://github.com/apache/servicecomb-service-center/pull/1126


   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    - [ ] Never comment source code, delete it.
    - [ ] UT should has "context, subject, expected result" result as test case name, when you call t.Run().
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #1126: set a complete token

Posted by GitBox <gi...@apache.org>.
little-cui commented on a change in pull request #1126:
URL: https://github.com/apache/servicecomb-service-center/pull/1126#discussion_r682722797



##########
File path: server/plugin/auth/buildin/buildin.go
##########
@@ -155,7 +155,7 @@ func (ba *TokenAuthenticator) VerifyToken(req *http.Request) (interface{}, error
 	if err != nil {
 		return nil, err
 	}
-	token.WithRequest(req, to)
+	token.WithRequest(req, v)

Review comment:
       不应该改这里，应该改signRequest，拼接jwt的header，也就是Bearer + token




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] Sphairis commented on a change in pull request #1126: set a complete token

Posted by GitBox <gi...@apache.org>.
Sphairis commented on a change in pull request #1126:
URL: https://github.com/apache/servicecomb-service-center/pull/1126#discussion_r683066837



##########
File path: server/plugin/auth/buildin/buildin.go
##########
@@ -155,7 +155,7 @@ func (ba *TokenAuthenticator) VerifyToken(req *http.Request) (interface{}, error
 	if err != nil {
 		return nil, err
 	}
-	token.WithRequest(req, to)
+	token.WithRequest(req, v)

Review comment:
       已修改




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #1126: set a complete token

Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #1126:
URL: https://github.com/apache/servicecomb-service-center/pull/1126


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #1126: set a complete token

Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #1126:
URL: https://github.com/apache/servicecomb-service-center/pull/1126


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] Sphairis commented on a change in pull request #1126: set a complete token

Posted by GitBox <gi...@apache.org>.
Sphairis commented on a change in pull request #1126:
URL: https://github.com/apache/servicecomb-service-center/pull/1126#discussion_r683066837



##########
File path: server/plugin/auth/buildin/buildin.go
##########
@@ -155,7 +155,7 @@ func (ba *TokenAuthenticator) VerifyToken(req *http.Request) (interface{}, error
 	if err != nil {
 		return nil, err
 	}
-	token.WithRequest(req, to)
+	token.WithRequest(req, v)

Review comment:
       已修改




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #1126: set a complete token

Posted by GitBox <gi...@apache.org>.
little-cui commented on a change in pull request #1126:
URL: https://github.com/apache/servicecomb-service-center/pull/1126#discussion_r682722797



##########
File path: server/plugin/auth/buildin/buildin.go
##########
@@ -155,7 +155,7 @@ func (ba *TokenAuthenticator) VerifyToken(req *http.Request) (interface{}, error
 	if err != nil {
 		return nil, err
 	}
-	token.WithRequest(req, to)
+	token.WithRequest(req, v)

Review comment:
       不应该改这里，应该改signRequest，拼接jwt的header，也就是Bearer + token




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org