[jira] [Commented] (ARROW-1184) [Java] Dictionary.equals is not working correctly

["Ji Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881725#comment-16881725 ] 

Ji Liu commented on ARROW-1184:
-------------------------------

[~bryanc] Now for Struct and List type, getObject returns JsonStringHashMap and JsonStringArrayList which support hashCode & equals well, I think we could simply apply compare logic in Validator to Dicitionary#equals, and make some change to make it work (e.g. add a wrapper for byte[] get from BinaryVector, now Object.equals(byte[], byte[]) I think is not correct). In this way, we need not add API for equals. What do you think?

 

> [Java] Dictionary.equals is not working correctly
> -------------------------------------------------
>
>                 Key: ARROW-1184
>                 URL: https://issues.apache.org/jira/browse/ARROW-1184
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Java
>            Reporter: Bryan Cutler
>            Priority: Major
>             Fix For: 1.0.0
>
>
> The {{Dictionary.equals}} method does not return True when the dictionaries are equal.  This is because {{equals}} is not implemented for FieldVector and so that comparison defaults to comparing the two objects only and not the vector data.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)