You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2023/01/19 15:29:00 UTC
[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678763#comment-17678763 ]
Ekaterina Dimitrova commented on CASSANDRA-18106:
-------------------------------------------------
Initial patch I was using in testing can be seen here - [https://github.com/riptano/ccm/compare/master...ekaterinadimitrova2:ccm:16895-trunk?expand=1]
A few remarks:
* it was created when trunk was 4.1, but I believe we will have to go for 5.0
* It relies on CASSANDRA_USE_JDK17 but this will have to change for 5.0+ considering CASSANDRA-18133 where CASSANDRA_USE_JDK11 or respectively CASSANDRA_USE_JDK17 (when we switch to 11+17) will be removed in favor of JdkProperties
* I think we will need to push the CCM patch and the switch to JdkProperties one after another as otherwise we need to add intermediate code which sounds counter-productive to me
CC [~mck] and [~brandon.williams]
> Update CCM for JDK17 and revise current JDK detection strategy
> --------------------------------------------------------------
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Reporter: Ekaterina Dimitrova
> Priority: Normal
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need to revise how we detect JDK versions in CCM and whether it is correct. To the best of my knowledge there are certain tests in the repo around that and they pass so my guess is we need to revise just the strategy and maybe document it explicitly or consider if we want any changes to be applied. Also, we need to be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org