[GitHub] [spark] LantaoJin commented on a change in pull request #27911: [SPARK-31154][SQL] Expose basic write metrics for InsertIntoDataSourceCommand

[GitBox <gi...@apache.org>]

LantaoJin commented on a change in pull request #27911: [SPARK-31154][SQL] Expose basic write metrics for InsertIntoDataSourceCommand
URL: https://github.com/apache/spark/pull/27911#discussion_r395009741
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala
 ##########
 @@ -292,7 +293,11 @@ trait PrunedFilteredScan {
  */
 @Stable
 trait InsertableRelation {
-  def insert(data: DataFrame, overwrite: Boolean): Unit
+  def insert(data: DataFrame, overwrite: Boolean): Unit = {}
+
+  def insert(data: DataFrame, overwrite: Boolean, metrics: Map[String, SQLMetric]): Unit = {
 
 Review comment:
   Does DSv2 have the similar interface? Current Delta Lake is using this command and besides this metrics, we have implemented ensure distribution for InsertIntoDataSource to support bucketing delta table. Does DSv1 accepte no more improvements? It has to move to DSv2?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org