[GitHub] [cloudstack-primate] ravening commented on a change in pull request #559: Fix global settings name display issue

[GitBox <gi...@apache.org>]

ravening commented on a change in pull request #559:
URL: https://github.com/apache/cloudstack-primate/pull/559#discussion_r462193958



##########
File path: src/components/view/ListView.vue
##########
@@ -68,7 +68,7 @@
         <os-logo v-if="record.ostypename" :osName="record.ostypename" size="1x" style="margin-right: 5px" />
         <console :resource="record" size="small" style="margin-right: 5px" />
 
-        <span v-if="$route.path.startsWith('/globalsetting')">{{ text }}</span>
+        <span v-if="$route.path.startsWith('/globalsetting')"></span>
         <span v-if="$route.path.startsWith('/alert')">

Review comment:
       @davidjumani can explain more? I didnt understand about the v-else-if part

##########
File path: src/components/view/ListView.vue
##########
@@ -68,7 +68,7 @@
         <os-logo v-if="record.ostypename" :osName="record.ostypename" size="1x" style="margin-right: 5px" />
         <console :resource="record" size="small" style="margin-right: 5px" />
 
-        <span v-if="$route.path.startsWith('/globalsetting')">{{ text }}</span>
+        <span v-if="$route.path.startsWith('/globalsetting')"></span>
         <span v-if="$route.path.startsWith('/alert')">

Review comment:
       @davidjumani the line `<span v-if="$route.path.startsWith('/globalsetting')">{{ text }}</span>` is displaying both plain text and the router link as shown in the screenshot above

##########
File path: src/components/view/ListView.vue
##########
@@ -68,7 +68,7 @@
         <os-logo v-if="record.ostypename" :osName="record.ostypename" size="1x" style="margin-right: 5px" />
         <console :resource="record" size="small" style="margin-right: 5px" />
 
-        <span v-if="$route.path.startsWith('/globalsetting')">{{ text }}</span>
+        <span v-if="$route.path.startsWith('/globalsetting')"></span>
         <span v-if="$route.path.startsWith('/alert')">

Review comment:
       @davidjumani done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org