You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2014/05/15 19:12:16 UTC
Review Request 21491: Fix KAFKA-1453
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21491/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1453
https://issues.apache.org/jira/browse/KAFKA-1453
Repository: kafka
Description
-------
Add a data channel size JMX
Diffs
-----
core/src/main/scala/kafka/tools/MirrorMaker.scala 26730c4a849045a6cd787b89ba5fa704e2524835
Diff: https://reviews.apache.org/r/21491/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 21491: Fix KAFKA-1453
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21491/#review43176
-----------------------------------------------------------
core/src/main/scala/kafka/tools/MirrorMaker.scala
<https://reviews.apache.org/r/21491/#comment77245>
Could we also add a metric that tracks the fraction of time that the consumer is blocked on putting data into the channel queue? That will give a clear indication weather the producer is slow.
core/src/main/scala/kafka/tools/MirrorMaker.scala
<https://reviews.apache.org/r/21491/#comment77246>
Similarly, could we also add a metric that measures the fraction of time the producer is waiting on get a message from the channel. That's an indication weather the consumer is feeding enough data to the producer. Perhaps both can be tracked in the DataChannel class.
- Jun Rao
On May 15, 2014, 5:12 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21491/
> -----------------------------------------------------------
>
> (Updated May 15, 2014, 5:12 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1453
> https://issues.apache.org/jira/browse/KAFKA-1453
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Add a data channel size JMX
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/MirrorMaker.scala 26730c4a849045a6cd787b89ba5fa704e2524835
>
> Diff: https://reviews.apache.org/r/21491/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 21491: Follow-up KAFKA-1453
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21491/
-----------------------------------------------------------
(Updated May 16, 2014, 4:56 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Follow-up KAFKA-1453
Bugs: KAFKA-1453
https://issues.apache.org/jira/browse/KAFKA-1453
Repository: kafka
Description
-------
Add a data channel size and producer/consumer wait-on-queue JMX
Diffs (updated)
-----
core/src/main/scala/kafka/tools/MirrorMaker.scala 19df3d566559a107f352ef471a8ad8f1c66f56a8
Diff: https://reviews.apache.org/r/21491/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 21491: Fix KAFKA-1453
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21491/
-----------------------------------------------------------
(Updated May 16, 2014, 2:05 a.m.)
Review request for kafka.
Bugs: KAFKA-1453
https://issues.apache.org/jira/browse/KAFKA-1453
Repository: kafka
Description
-------
Add a data channel size and producer/consumer wait-on-queue JMX
Diffs (updated)
-----
core/src/main/scala/kafka/tools/MirrorMaker.scala 26730c4a849045a6cd787b89ba5fa704e2524835
Diff: https://reviews.apache.org/r/21491/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 21491: Fix KAFKA-1453
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21491/
-----------------------------------------------------------
(Updated May 16, 2014, 12:33 a.m.)
Review request for kafka.
Bugs: KAFKA-1453
https://issues.apache.org/jira/browse/KAFKA-1453
Repository: kafka
Description
-------
Add a data channel size and producer/consumer wait-on-queue JMX
Diffs (updated)
-----
core/src/main/scala/kafka/tools/MirrorMaker.scala 26730c4a849045a6cd787b89ba5fa704e2524835
Diff: https://reviews.apache.org/r/21491/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 21491: Fix KAFKA-1453
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21491/
-----------------------------------------------------------
(Updated May 15, 2014, 11:57 p.m.)
Review request for kafka.
Bugs: KAFKA-1453
https://issues.apache.org/jira/browse/KAFKA-1453
Repository: kafka
Description (updated)
-------
Add a data channel size and producer/consumer wait-on-queue JMX
Diffs (updated)
-----
core/src/main/scala/kafka/tools/MirrorMaker.scala 26730c4a849045a6cd787b89ba5fa704e2524835
Diff: https://reviews.apache.org/r/21491/diff/
Testing
-------
Thanks,
Guozhang Wang