You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "tmedicci (via GitHub)" <gi...@apache.org> on 2024/02/19 11:45:59 UTC
[PR] risc-v/esp_: Implement the RMT peripheral for all the supported Risc-V ESP32 devices [nuttx]
tmedicci opened a new pull request, #11721:
URL: https://github.com/apache/nuttx/pull/11721
## Summary
* Documentation: Add entry about the RMT peripheral for the ESP32 family
* risc-v/esp_<rmt|ws2812>: Implement the RMT peripheral for ESP32 RVs
* This commit implements the RMT peripheral for all the supported Espressif's RISC-V devices. It also implements the support for the WS2812 addressable RGB LED using the RMT peripheral.
* boards/esp32s2-saola-1: Change the RMT output pin to the on-board LED
* xtensa/esp_ws2812: Get actual RMT clock to encode WS2812 data
* WS2812 data is encoded into RMT items according to the RMT clock source. This commit makes it by using the actual clock source in spite of a pre-defined value.
Please note that this PR is very similar to the one submitted to provide the RMT support for xtensa-based ESP32 devices: https://github.com/apache/nuttx/pull/11428 (this includes the sources of the common driver).
## Impact
Implement the common driver for the RMT peripheral on ESP32 Risc-V-based devices.
## Testing
Internal CI testing + ESP32-S2-Saola-1 board and ESP32-S3-DevKitC-1 v1.0 board (loopback test + WS2812 LED strip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] risc-v/esp_: Implement the RMT peripheral for all the supported Risc-V ESP32 devices [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #11721:
URL: https://github.com/apache/nuttx/pull/11721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] risc-v/esp_: Implement the RMT peripheral for all the supported Risc-V ESP32 devices [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #11721:
URL: https://github.com/apache/nuttx/pull/11721#discussion_r1494433823
##########
boards/risc-v/esp32h2/esp32h2-devkit/src/esp32h2-devkit.h:
##########
@@ -31,6 +31,19 @@
* Pre-processor Definitions
****************************************************************************/
+/* RMT gpio */
+
+#define RMT_RXCHANNEL 2
+#define RMT_TXCHANNEL 0
+
+#ifdef CONFIG_RMT_LOOP_TEST_MODE
+# define RMT_INPUT_PIN 0
Review Comment:
remove two space to algin with line 37
##########
boards/risc-v/esp32c3/esp32c3-generic/src/esp32c3-generic.h:
##########
@@ -31,6 +31,19 @@
* Pre-processor Definitions
****************************************************************************/
+/* RMT gpio */
+
+#define RMT_RXCHANNEL 2
+#define RMT_TXCHANNEL 0
+
+#ifdef CONFIG_RMT_LOOP_TEST_MODE
+# define RMT_INPUT_PIN 0
Review Comment:
ditto
##########
boards/risc-v/esp32c6/esp32c6-devkit/src/esp32c6-devkit.h:
##########
@@ -31,6 +31,19 @@
* Pre-processor Definitions
****************************************************************************/
+/* RMT gpio */
+
+#define RMT_RXCHANNEL 2
+#define RMT_TXCHANNEL 0
+
+#ifdef CONFIG_RMT_LOOP_TEST_MODE
+# define RMT_INPUT_PIN 0
Review Comment:
remove two space to align with line 37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org