You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Nick Zalabak (JIRA)" <ji...@apache.org> on 2012/06/14 20:04:42 UTC
[jira] [Created] (THRIFT-1629) Ruby 1.9 Compatibility during Thrift
configure, make, install
Nick Zalabak created THRIFT-1629:
------------------------------------
Summary: Ruby 1.9 Compatibility during Thrift configure, make, install
Key: THRIFT-1629
URL: https://issues.apache.org/jira/browse/THRIFT-1629
Project: Thrift
Issue Type: Improvement
Components: Ruby - Compiler, Ruby - Library
Affects Versions: 0.8
Environment: Mac OSX, *nix
Reporter: Nick Zalabak
I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9. The Ruby community is deprecating 1.8 soon and moving forward with the language quickly.
The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
I would be delighted to help out with Thrift and it's support for Ruby if someone isn't already working on it.
Please let me know.
Thanks.
Nick Zalabak
@techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1629) Ruby 1.9 Compatibility during
Thrift configure, make, install
Posted by "Nick Zalabak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409774#comment-13409774 ]
Nick Zalabak commented on THRIFT-1629:
--------------------------------------
I didn't see any comment on the pull request I submitted. The pull request removes Mongrel entirely, replaces it with Thin, a more modern Ruby web server that is compatible with Ruby 1.8 and 1.9. This would eliminate the problem during configuring, making, and installing.
https://github.com/apache/thrift/pull/23
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
> Key: THRIFT-1629
> URL: https://issues.apache.org/jira/browse/THRIFT-1629
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.8
> Environment: Mac OSX, *nix
> Reporter: Nick Zalabak
>
> I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
> I have submitted a pull request via Github to resolve this matter.
> https://github.com/apache/thrift/pull/23
> Thanks.
> Nick Zalabak
> @techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1629) Ruby 1.9 Compatibility during Thrift
configure, make, install
Posted by "Nick Zalabak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Zalabak updated THRIFT-1629:
---------------------------------
Component/s: (was: Ruby - Compiler)
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
> Key: THRIFT-1629
> URL: https://issues.apache.org/jira/browse/THRIFT-1629
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.8
> Environment: Mac OSX, *nix
> Reporter: Nick Zalabak
>
> I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
> I have submitted a pull request via Github to resolve this matter.
> https://github.com/apache/thrift/pull/23
> Thanks.
> Nick Zalabak
> @techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (THRIFT-1629) Ruby 1.9 Compatibility during
Thrift configure, make, install
Posted by "Nick Zalabak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Zalabak reopened THRIFT-1629:
----------------------------------
No comment on the pull request I submitted?
https://github.com/apache/thrift/pull/23
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
> Key: THRIFT-1629
> URL: https://issues.apache.org/jira/browse/THRIFT-1629
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.8
> Environment: Mac OSX, *nix
> Reporter: Nick Zalabak
>
> I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
> I have submitted a pull request via Github to resolve this matter.
> https://github.com/apache/thrift/pull/23
> Thanks.
> Nick Zalabak
> @techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1629) Ruby 1.9 Compatibility during
Thrift configure, make, install
Posted by "Nick Zalabak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410549#comment-13410549 ]
Nick Zalabak commented on THRIFT-1629:
--------------------------------------
Thanks Jake.
I will submit the patch based on the "How to Contribute" instructions.
There are a just a few new additions to the dependency chain for the added benefit of cross compatibility. In terms of the Thrift Ruby client gemspec though, it should be setup to specify runtime and development dependencies. At the moment it doesn't specify runtime deps and it really ought too. Not specifying runtime deps makes the gem difficult to use especially when added to application stacks with sizable dependency chains. In fact, I will make another patch that addresses this as well.
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
> Key: THRIFT-1629
> URL: https://issues.apache.org/jira/browse/THRIFT-1629
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.8
> Environment: Mac OSX, *nix
> Reporter: Nick Zalabak
>
> I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
> I have submitted a pull request via Github to resolve this matter.
> https://github.com/apache/thrift/pull/23
> Thanks.
> Nick Zalabak
> @techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (THRIFT-1629) Ruby 1.9 Compatibility during
Thrift configure, make, install
Posted by "Nick Zalabak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409774#comment-13409774 ]
Nick Zalabak edited comment on THRIFT-1629 at 7/9/12 7:47 PM:
--------------------------------------------------------------
I didn't see any comment on the pull request I submitted. The pull request removes Mongrel entirely, replaces it with Thin, which is compatible with Ruby 1.8 and 1.9. This would eliminate the problem during configuring, making, and installing and the --pre flag.
I also don't understand how it is marked as not a problem if developers aren't able to simply grab the latest stable copy of Thrift and compile and test it successfully without additional complexities of compiler and dependency hacks. The Ruby client shouldn't specify an abandoned dependency, namely Mongrel, that no longer has an active maintainer.
https://github.com/apache/thrift/pull/23
was (Author: techwhizbang):
I didn't see any comment on the pull request I submitted. The pull request removes Mongrel entirely, replaces it with Thin, a more modern Ruby web server that is compatible with Ruby 1.8 and 1.9. This would eliminate the problem during configuring, making, and installing.
https://github.com/apache/thrift/pull/23
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
> Key: THRIFT-1629
> URL: https://issues.apache.org/jira/browse/THRIFT-1629
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.8
> Environment: Mac OSX, *nix
> Reporter: Nick Zalabak
>
> I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
> I have submitted a pull request via Github to resolve this matter.
> https://github.com/apache/thrift/pull/23
> Thanks.
> Nick Zalabak
> @techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1629) Ruby 1.9 Compatibility during Thrift
configure, make, install
Posted by "Nick Zalabak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Zalabak updated THRIFT-1629:
---------------------------------
Description:
I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
I have submitted a pull request via Github to resolve this matter.
https://github.com/apache/thrift/pull/23
Thanks.
Nick Zalabak
@techwhizbang
was:
I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
I would be delighted to help out with Thrift and it's support for Ruby 1.9 if someone isn't already working on this issue.
Thanks.
Nick Zalabak
@techwhizbang
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
> Key: THRIFT-1629
> URL: https://issues.apache.org/jira/browse/THRIFT-1629
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Compiler, Ruby - Library
> Affects Versions: 0.8
> Environment: Mac OSX, *nix
> Reporter: Nick Zalabak
>
> I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
> I have submitted a pull request via Github to resolve this matter.
> https://github.com/apache/thrift/pull/23
> Thanks.
> Nick Zalabak
> @techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1629) Ruby 1.9 Compatibility during Thrift
configure, make, install
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell closed THRIFT-1629.
--------------------------------
Resolution: Not A Problem
This issue is between ruby 1.9 and the mongrel gem, this has been documented in several previous tickets and on the dev mailing list as a ruby specific issue and not a Thrift issue. Install the --pre version of mongrel will fix your problem.
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
> Key: THRIFT-1629
> URL: https://issues.apache.org/jira/browse/THRIFT-1629
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.8
> Environment: Mac OSX, *nix
> Reporter: Nick Zalabak
>
> I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
> I have submitted a pull request via Github to resolve this matter.
> https://github.com/apache/thrift/pull/23
> Thanks.
> Nick Zalabak
> @techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1629) Ruby 1.9 Compatibility during
Thrift configure, make, install
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410416#comment-13410416 ]
Jake Farrell commented on THRIFT-1629:
--------------------------------------
Nick, we do not currently accept github pull requests, please see http://thrift.apache.org/docs/HowToContribute/ for information on submitting a patch. Also your patch isn't against trunk which shows the dependencies as the following
s.add_development_dependency "rake"
s.add_development_dependency "rspec", "1.3.2"
s.add_development_dependency "mongrel"
vs your patch which has
s.add_development_dependency "rake", "~> 0.9.2.2"
s.add_development_dependency "rspec", "1.3.2"
s.add_development_dependency "rack", "~> 1.4.1"
s.add_development_dependency "rack-test", "~> 0.6.1"
s.add_development_dependency "thin", "~> 1.3.1"
s.add_development_dependency "bundler", "~> 1.1.4"
I am all for using the best option for maintainability and cross version stability, but I would like to avoid adding more dependencies to help keep things easier to debug.
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
> Key: THRIFT-1629
> URL: https://issues.apache.org/jira/browse/THRIFT-1629
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.8
> Environment: Mac OSX, *nix
> Reporter: Nick Zalabak
>
> I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
> I have submitted a pull request via Github to resolve this matter.
> https://github.com/apache/thrift/pull/23
> Thanks.
> Nick Zalabak
> @techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1629) Ruby 1.9 Compatibility during Thrift
configure, make, install
Posted by "Nick Zalabak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Zalabak updated THRIFT-1629:
---------------------------------
Description:
I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
I would be delighted to help out with Thrift and it's support for Ruby 1.9 if someone isn't already working on this issue.
Thanks.
Nick Zalabak
@techwhizbang
was:
I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9. The Ruby community is deprecating 1.8 soon and moving forward with the language quickly.
The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
I would be delighted to help out with Thrift and it's support for Ruby if someone isn't already working on it.
Please let me know.
Thanks.
Nick Zalabak
@techwhizbang
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
> Key: THRIFT-1629
> URL: https://issues.apache.org/jira/browse/THRIFT-1629
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Compiler, Ruby - Library
> Affects Versions: 0.8
> Environment: Mac OSX, *nix
> Reporter: Nick Zalabak
>
> I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
> I would be delighted to help out with Thrift and it's support for Ruby 1.9 if someone isn't already working on this issue.
> Thanks.
> Nick Zalabak
> @techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1629) Ruby 1.9 Compatibility during
Thrift configure, make, install
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell reassigned THRIFT-1629:
------------------------------------
Assignee: Jake Farrell
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
> Key: THRIFT-1629
> URL: https://issues.apache.org/jira/browse/THRIFT-1629
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.8
> Environment: Mac OSX, *nix
> Reporter: Nick Zalabak
> Assignee: Jake Farrell
>
> I downloaded the 0.8 stable version of Thrift and began by performing the configure, make tasks. It appears that this version of Thrift is not compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in replacement for Mongrel is the Thin web server, and there are also several other choices.
> I have submitted a pull request via Github to resolve this matter.
> https://github.com/apache/thrift/pull/23
> Thanks.
> Nick Zalabak
> @techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira