[GitHub] [ignite] alex-plekhanov commented on a change in pull request #6638: IGNITE-11941: VM metrics moved to GridMetricManager.

[GitBox <gi...@apache.org>]

alex-plekhanov commented on a change in pull request #6638:  IGNITE-11941: VM metrics moved to GridMetricManager.
URL: https://github.com/apache/ignite/pull/6638#discussion_r298627607
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/ClusterMetricsImpl.java
 ##########
 @@ -270,27 +409,27 @@ public ClusterMetricsImpl(GridKernalContext ctx, GridLocalMetrics vmMetrics, lon
 
     /** {@inheritDoc} */
     @Override public long getNonHeapMemoryCommitted() {
-        return vmMetrics.getNonHeapMemoryCommitted();
+        return nonHeapCommitted.value();
     }
 
     /** {@inheritDoc} */
     @Override public long getNonHeapMemoryMaximum() {
-        return vmMetrics.getNonHeapMemoryMaximum();
+        return nonHeapMax.value();
     }
 
     /** {@inheritDoc} */
     @Override public long getNonHeapMemoryTotal() {
-        return vmMetrics.getNonHeapMemoryMaximum();
+        return nonHeapMax.value();
     }
 
     /** {@inheritDoc} */
     @Override public long getUpTime() {
-        return vmMetrics.getUptime();
+        return upTime.value();
     }
 
     /** {@inheritDoc} */
     @Override public long getStartTime() {
-        return vmMetrics.getStartTime();
+        return rt.getStartTime();
 
 Review comment:
   Why different approaches are used for `getUpTime()` and `getStartTime()`? Both from the same MXBean, both used only once in `ClusterMetricsImpl`. Wouldn't it be better to get start time from the metrics registry too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services