You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/07/18 14:24:12 UTC
[GitHub] [ozone] Galsza opened a new pull request, #3605: HDDS-6807 remove tcnative.version dependency
Galsza opened a new pull request, #3605:
URL: https://github.com/apache/ozone/pull/3605
## What changes were proposed in this pull request?
Removed the tcnative property from dependencies at it is already included in netty.
## What is the link to the Apache JIRA
Here is the link: [HDDS-6807](https://issues.apache.org/jira/browse/HDDS-6807)
## How was this patch tested?
All unit/integration tests were run in the forked repository's pipeline as well as local deployment to see if the application still runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3605: HDDS-6807. Remove tcnative.version property
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3605:
URL: https://github.com/apache/ozone/pull/3605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3605: HDDS-6807. Remove tcnative.version property
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3605:
URL: https://github.com/apache/ozone/pull/3605#issuecomment-1191114864
Thanks @Galsza for the patch, @neils-dev and @smengcl for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3605: HDDS-6807. Remove tcnative.version property
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3605:
URL: https://github.com/apache/ozone/pull/3605#issuecomment-1191103221
Thanks @neils-dev for the review.
> has it been tested on different archs _linux, osx_?
Tested on Linux (CI). We don't have a secure test env. for other platforms. `netty-tcnative-boringssl-static-2.0.48.Final.jar` has the native libs for all supported (by Netty) platforms:
```
testing: META-INF/native/libnetty_tcnative_linux_aarch_64.so OK
testing: META-INF/native/libnetty_tcnative_linux_x86_64.so OK
testing: META-INF/native/libnetty_tcnative_osx_aarch_64.jnilib OK
testing: META-INF/native/libnetty_tcnative_osx_x86_64.jnilib OK
testing: META-INF/native/netty_tcnative_windows_x86_64.dll OK
```
So I think it should work just as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] neils-dev commented on pull request #3605: HDDS-6807. Remove tcnative.version property
Posted by GitBox <gi...@apache.org>.
neils-dev commented on PR #3605:
URL: https://github.com/apache/ozone/pull/3605#issuecomment-1190637465
Thanks @Galsza for the patch and @adoroszlai for following this up from HDDS-6097. Looks good. With the `netty bom` providing the versions for `netty-tcnative-boringssl-static` and indirectly through that including `netty-tcnative` with the proper arch (linux-aarch_64, osx-x86_64), it looks much cleaner and works well. Q. has it been tested on different archs _linux, osx_?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3605: HDDS-6807. Remove tcnative.version property
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3605:
URL: https://github.com/apache/ozone/pull/3605#issuecomment-1189894609
@neils-dev would you like to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org