You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2016/12/14 22:34:04 UTC

[2/3] incubator-beam git commit: Fix NPE in StatefulParDoEvaluatorFactoryTest mocking

Fix NPE in StatefulParDoEvaluatorFactoryTest mocking


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/d9f24b86
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/d9f24b86
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/d9f24b86

Branch: refs/heads/release-0.4.0-incubating
Commit: d9f24b86c644ea85fd197eaab4c2d16b20a70d5f
Parents: 122f051
Author: Kenneth Knowles <kl...@google.com>
Authored: Wed Dec 14 13:12:43 2016 -0800
Committer: Kenneth Knowles <kl...@google.com>
Committed: Wed Dec 14 14:00:14 2016 -0800

----------------------------------------------------------------------
 .../beam/runners/direct/StatefulParDoEvaluatorFactoryTest.java | 6 ++++++
 1 file changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/d9f24b86/runners/direct-java/src/test/java/org/apache/beam/runners/direct/StatefulParDoEvaluatorFactoryTest.java
----------------------------------------------------------------------
diff --git a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/StatefulParDoEvaluatorFactoryTest.java b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/StatefulParDoEvaluatorFactoryTest.java
index 7c086a1..326310b 100644
--- a/runners/direct-java/src/test/java/org/apache/beam/runners/direct/StatefulParDoEvaluatorFactoryTest.java
+++ b/runners/direct-java/src/test/java/org/apache/beam/runners/direct/StatefulParDoEvaluatorFactoryTest.java
@@ -31,6 +31,7 @@ import com.google.common.collect.Iterables;
 import com.google.common.collect.Lists;
 import java.io.Serializable;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import org.apache.beam.runners.direct.DirectRunner.CommittedBundle;
 import org.apache.beam.runners.direct.DirectRunner.UncommittedBundle;
@@ -94,6 +95,11 @@ public class StatefulParDoEvaluatorFactoryTest implements Serializable {
   public void setup() {
     MockitoAnnotations.initMocks(this);
     when((StateInternals<Object>) mockStepContext.stateInternals()).thenReturn(stateInternals);
+    when(mockEvaluationContext.createSideInputReader(anyList()))
+        .thenReturn(
+            SideInputContainer.create(
+                    mockEvaluationContext, Collections.<PCollectionView<?>>emptyList())
+                .createReaderForViews(Collections.<PCollectionView<?>>emptyList()));
   }
 
   @Test