You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2019/08/02 03:00:45 UTC
[kudu] 03/03: tools: fix warning when compiling in ASAN and TSAN
caused by ConvertToKuduPartialRow.
This is an automated email from the ASF dual-hosted git repository.
adar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit bc80ccc5b630cfa2c8d29889553780f0a1c7e5ef
Author: honeyhexin <ho...@sohu.com>
AuthorDate: Thu Aug 1 12:38:08 2019 +0800
tools: fix warning when compiling in ASAN and TSAN caused by ConvertToKuduPartialRow.
This is a follow-up to 58e01492320f954cd1 to fix warning in compile log
when build type is TSAN or ASAN.
Change-Id: I6307be31e56ebe0999c82d3bb66f2823d6fb0d03
Reviewed-on: http://gerrit.cloudera.org:8080/13974
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
src/kudu/tools/tool_action_table.cc | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/kudu/tools/tool_action_table.cc b/src/kudu/tools/tool_action_table.cc
index 0abed54..f5cbed2 100644
--- a/src/kudu/tools/tool_action_table.cc
+++ b/src/kudu/tools/tool_action_table.cc
@@ -520,7 +520,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractInt64(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetInt8(col_name, static_cast<int8_t>(value));
+ RETURN_NOT_OK(range_bound_partial_row->SetInt8(col_name, static_cast<int8_t>(value)));
break;
}
case KuduColumnSchema::INT16: {
@@ -528,7 +528,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractInt64(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetInt16(col_name, static_cast<int16_t>(value));
+ RETURN_NOT_OK(range_bound_partial_row->SetInt16(col_name, static_cast<int16_t>(value)));
break;
}
case KuduColumnSchema::INT32: {
@@ -536,7 +536,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractInt32(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetInt32(col_name, value);
+ RETURN_NOT_OK(range_bound_partial_row->SetInt32(col_name, value));
break;
}
case KuduColumnSchema::INT64: {
@@ -544,7 +544,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractInt64(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetInt64(col_name, value);
+ RETURN_NOT_OK(range_bound_partial_row->SetInt64(col_name, value));
break;
}
case KuduColumnSchema::UNIXTIME_MICROS: {
@@ -552,7 +552,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractInt64(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetUnixTimeMicros(col_name, value);
+ RETURN_NOT_OK(range_bound_partial_row->SetUnixTimeMicros(col_name, value));
break;
}
case KuduColumnSchema::BINARY: {
@@ -560,7 +560,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractString(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetBinary(col_name, value);
+ RETURN_NOT_OK(range_bound_partial_row->SetBinary(col_name, value));
break;
}
case KuduColumnSchema::STRING: {
@@ -568,7 +568,7 @@ Status ConvertToKuduPartialRow(const client::sp::shared_ptr<KuduTable>& table,
RETURN_NOT_OK_PREPEND(
reader.ExtractString(values[i], /*field=*/nullptr, &value),
error_msg);
- range_bound_partial_row->SetString(col_name, value);
+ RETURN_NOT_OK(range_bound_partial_row->SetString(col_name, value));
break;
}
case KuduColumnSchema::BOOL: