[GitHub] rnewson commented on a change in pull request #1072: Decode destination header for doc copy

[GitBox <gi...@apache.org>]

rnewson commented on a change in pull request #1072: Decode destination header for doc copy
URL: https://github.com/apache/couchdb/pull/1072#discussion_r158022395
 
 

 ##########
 File path: src/chttpd/src/chttpd_db.erl
 ##########
 @@ -825,7 +825,8 @@ db_doc_req(#httpd{method='COPY', user_ctx=Ctx}=Req, Db, SourceDocId) ->
         missing_rev -> nil;
         Rev -> Rev
     end,
-    {TargetDocId, TargetRevs} = couch_httpd_db:parse_copy_destination_header(Req),
+    {TargetDocId0, TargetRevs} = couch_httpd_db:parse_copy_destination_header(Req),
+    TargetDocId = list_to_binary(mochiweb_util:unquote(TargetDocId0)),
 
 Review comment:
   
   
   I think the problem here is that the doc id isn't always escaped (that change is fairly recent).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services