You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/06/08 21:39:27 UTC
[GitHub] couchdb-fauxton pull request: [WIP] Zen mode
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/458
[WIP] Zen mode
This adds a zen-mode option to small Ace Editor fields to allow a lot more real estate for entering code. See screenshots:
Icon:
Dark zen-mode (default):
Light zen-mode:
The choice of theme (dark/light) is remembered in local storage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton zen-mode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #458
----
commit c0ddff2c267c45d6d2d6a164ca3cbd3d623b5978
Author: Ben Keen <be...@gmail.com>
Date: 2015-06-04T20:00:49Z
starting on zen mode option for code editor
commit 0fedc42ac46ad9d705f28ee484e7b0ada85ac0a0
Author: Ben Keen <be...@gmail.com>
Date: 2015-06-04T22:52:21Z
continued work
commit 2ea959c6776aa5e9b45a632d5467050f6cf1e29a
Author: Ben Keen <be...@gmail.com>
Date: 2015-06-05T15:42:29Z
blah blah commit message here
commit 178fe611854064a8e6f6b254ae521723310043f2
Author: Ben Keen <be...@gmail.com>
Date: 2015-06-08T19:38:01Z
working
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Zen Mode option for small Ace Editor...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/458#issuecomment-110164888
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: [WIP] Zen mode
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/458#issuecomment-110123622
@kxepal the "idle fingers" theme we use throughout Fauxton just doesn't work with light background (see example below). I started tweaking it, but then figured it was kind of pointless: we'll end up with two different themes anyway. So instead I just picked a theme already designed for a white background.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: [WIP] Zen mode
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/458#issuecomment-110120032
i think this is really neat! :grinning:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Zen Mode option for small Ace Editor...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Zen Mode option for small Ace Editor...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/458#issuecomment-110221545
hey ben, was just thinking,
I think people kind of like being able to code on one side, and see the results on the other. Is there a way to make a medium editor, that takes up half the screen (a middle panel-sized editor) with the save button still there for fast previewing? Or maybe a re-sizeable editor?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: [WIP] Zen mode
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/458#issuecomment-110120827
Why code highlight is different in dark/light modes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Zen Mode option for small Ace Editor...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/458#issuecomment-110209281
Merged as b1e6332
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---