You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@burr.apache.org by "Ghraven (via GitHub)" <gi...@apache.org> on 2026/08/08 04:08:33 UTC
[PR] fix(ui): harden token costs refresh script [burr]
Ghraven opened a new pull request, #876:
URL: https://github.com/apache/burr/pull/876
## Problem
The token-cost refresh script fetches LiteLLM's model pricing JSON and writes `model_costs.json`, but the network request can hang indefinitely and HTTP failures are not surfaced explicitly. The generated JSON write also relied on the platform default text encoding.
## Before / after
Before:
- `requests.get()` used no timeout.
- HTTP error responses were passed straight to JSON parsing.
- `model_costs.json` was written with the default platform encoding.
After:
- the request has a bounded timeout,
- HTTP failures raise through `raise_for_status()`, and
- the generated JSON is written as UTF-8.
## Verification
- `python -m py_compile telemetry/ui/scripts/token_costs.py`
- Ran `telemetry/ui/scripts/token_costs.py` from a temporary working directory and confirmed it generated `model_costs.json`
- `git diff --check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): harden token costs refresh script [burr]
Posted by "elijahbenizzy (via GitHub)" <gi...@apache.org>.
elijahbenizzy closed pull request #876: fix(ui): harden token costs refresh script
URL: https://github.com/apache/burr/pull/876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ui): harden token costs refresh script [burr]
Posted by "elijahbenizzy (via GitHub)" <gi...@apache.org>.
elijahbenizzy commented on PR #876:
URL: https://github.com/apache/burr/pull/876#issuecomment-6235583521
Thanks for this. The same change landed on main via #918, so the diff here is now empty against main. Closing as superseded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org