[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1336: Remove the test db dir after deleting the storage in CPP unittest

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk commented on code in PR #1336:
URL: https://github.com/apache/incubator-kvrocks/pull/1336#discussion_r1141830528


##########
tests/cppunit/test_base.h:
##########
@@ -43,13 +43,13 @@ class TestBase : public testing::Test {
     }
   }
   ~TestBase() override {
+    delete storage_;
+    delete config_;
     std::error_code ec;
     std::filesystem::remove_all(config_->db_dir, ec);

Review Comment:
   > This line holds a ref to `confg_` but we `delete config_` above.
   
   Yes, my bad, fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org