You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Sönke Liebau (JIRA)" <ji...@apache.org> on 2018/02/13 23:28:00 UTC
[jira] [Created] (KAFKA-6561) Change visibility of aclMatch in
SimpleAclAuthorizer to protected to allow overriding in subclasses
Sönke Liebau created KAFKA-6561:
-----------------------------------
Summary: Change visibility of aclMatch in SimpleAclAuthorizer to protected to allow overriding in subclasses
Key: KAFKA-6561
URL: https://issues.apache.org/jira/browse/KAFKA-6561
Project: Kafka
Issue Type: Improvement
Components: core
Affects Versions: 1.0.0
Reporter: Sönke Liebau
Assignee: Sönke Liebau
Currently the visibility of the [aclMatch|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/security/auth/SimpleAclAuthorizer.scala#L146] function in the SimpleAclAuthorizer class is set to private, thus prohibiting subclasses from overriding this method. I think this was originally done as this function is not supposed to be part of the public Api of this class, which makes sense.
However when creating a custom authorizer this would be a very useful method to override, as it allows to reuse a large amount of boilerplate code around loading and applying ACLs and simply changing the way that ACLs are matched.
Could we change the visibility of this method to protected, thus still keeping it out of the public interface but allowing for subclasses to override it?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)