You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/21 00:11:35 UTC
[GitHub] [spark] farhan5900 opened a new pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
farhan5900 opened a new pull request #30112:
URL: https://github.com/apache/spark/pull/30112
### What changes were proposed in this pull request?
This PR removes generic `shellEscape` and put it in specific places. More specifically shell-escape only appName, mainClass, default, and driverConf.
### Why are the changes needed?
Changes are needed because we see PySpark jobs fail to launch when 1) run with docker and 2) including --py-files
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
- Unit Test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713554521
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34701/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713565698
**[Test build #130095 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130095/testReport)** for PR 30112 at commit [`89e2671`](https://github.com/apache/spark/commit/89e2671254ecb96bf48090b8fe31664545cb719c).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713556391
**[Test build #130095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130095/testReport)** for PR 30112 at commit [`89e2671`](https://github.com/apache/spark/commit/89e2671254ecb96bf48090b8fe31664545cb719c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713615157
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34705/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713595241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713240583
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34671/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713595241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713594780
**[Test build #130096 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130096/testReport)** for PR 30112 at commit [`8d0d329`](https://github.com/apache/spark/commit/8d0d3295a5a86bde5422214a87e143cd1221c143).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713213685
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713535658
**[Test build #130092 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130092/testReport)** for PR 30112 at commit [`30a0459`](https://github.com/apache/spark/commit/30a045968060db31a3530dd30d63ccffa2cbecb5).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713228426
**[Test build #130063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130063/testReport)** for PR 30112 at commit [`d5435d2`](https://github.com/apache/spark/commit/d5435d25bbe8acc9b6bbf0f2b9fd1ea7f80e8af4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713629732
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713585750
**[Test build #130096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130096/testReport)** for PR 30112 at commit [`8d0d329`](https://github.com/apache/spark/commit/8d0d3295a5a86bde5422214a87e143cd1221c143).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713535686
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713229164
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130063/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713584787
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34704/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] farhan5900 commented on a change in pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
farhan5900 commented on a change in pull request #30112:
URL: https://github.com/apache/spark/pull/30112#discussion_r509395553
##########
File path: resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
##########
@@ -30,6 +30,7 @@ import org.mockito.Mockito._
import org.scalatestplus.mockito.MockitoSugar
import org.apache.spark.{LocalSparkContext, SparkConf, SparkFunSuite}
+import org.apache.spark.internal.config._
Review comment:
Fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713213685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713228426
**[Test build #130063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130063/testReport)** for PR 30112 at commit [`d5435d2`](https://github.com/apache/spark/commit/d5435d25bbe8acc9b6bbf0f2b9fd1ea7f80e8af4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713211454
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] farhan5900 commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
farhan5900 commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-716613161
Hi, @dongjoon-hyun It is basically done to avoid shell-escaping of the `$MESOS_SANDBOX` used in the case of `--py-files` with the docker option (`spark..mesos.executor.docker.image`) provided.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713565755
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713556391
**[Test build #130095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130095/testReport)** for PR 30112 at commit [`89e2671`](https://github.com/apache/spark/commit/89e2671254ecb96bf48090b8fe31664545cb719c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713531413
**[Test build #130092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130092/testReport)** for PR 30112 at commit [`30a0459`](https://github.com/apache/spark/commit/30a045968060db31a3530dd30d63ccffa2cbecb5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713248232
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34671/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713571381
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34701/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713605562
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34704/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713248251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713229143
**[Test build #130063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130063/testReport)** for PR 30112 at commit [`d5435d2`](https://github.com/apache/spark/commit/d5435d25bbe8acc9b6bbf0f2b9fd1ea7f80e8af4).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713535698
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130092/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #30112:
URL: https://github.com/apache/spark/pull/30112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30112:
URL: https://github.com/apache/spark/pull/30112#discussion_r508964711
##########
File path: resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
##########
@@ -30,6 +30,7 @@ import org.mockito.Mockito._
import org.scalatestplus.mockito.MockitoSugar
import org.apache.spark.{LocalSparkContext, SparkConf, SparkFunSuite}
+import org.apache.spark.internal.config._
Review comment:
Hi, @farhan5900 . Could you run `dev/lint-scala`? This should be moved to at line 37.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713629704
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34705/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713565755
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713225959
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713605597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713571424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713229156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713248251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30112: [SPARK-33199] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713211454
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713585750
**[Test build #130096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130096/testReport)** for PR 30112 at commit [`8d0d329`](https://github.com/apache/spark/commit/8d0d3295a5a86bde5422214a87e143cd1221c143).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713605597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] farhan5900 edited a comment on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
farhan5900 edited a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-716613161
Hi, @dongjoon-hyun It is basically done to avoid shell-escaping of the `$MESOS_SANDBOX` used in the case of `--py-files` with the docker image option (`spark.mesos.executor.docker.image`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713629732
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713531413
**[Test build #130092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130092/testReport)** for PR 30112 at commit [`30a0459`](https://github.com/apache/spark/commit/30a045968060db31a3530dd30d63ccffa2cbecb5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-779513807
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30112: [SPARK-33199][MESOS] Mesos Task Failed when pyFiles and docker image option used together
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30112:
URL: https://github.com/apache/spark/pull/30112#issuecomment-713535686
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org