You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by bu...@apache.org on 2015/07/16 00:47:39 UTC

4.1.2_release_blocker requested: [Issue 126401] Add ASF license headers to files

Kay <ks...@apache.org> has asked  for 4.1.2_release_blocker:
Issue 126401: Add ASF license headers to files
https://bz.apache.org/ooo/show_bug.cgi?id=126401

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: 4.1.2_release_blocker requested: [Issue 126401] Add ASF license headers to files

Posted by Kay Schenk <ka...@gmail.com>.
On Fri, Jul 17, 2015 at 3:00 PM, Andrea Pescetti <pe...@apache.org>
wrote:

> On 16/07/2015 bugzilla wrote:
>
>> Kay has asked for 4.1.2_release_blocker:
>> Issue 126401: Add ASF license headers to files
>> https://bz.apache.org/ooo/show_bug.cgi?id=126401
>>
>
> Unless I'm really mistaken this does not apply to AOO410: those files do
> not exist in AOO410, as I wrote yesterday. But Kay is the third person
> mentioning this issue after Jan and Marcus, so if I am the one who is wrong
> just show me the path on AOO410 where the patch should be applied and I'll
> definitely take a look.
>
> What I see is:
> https://svn.apache.org/viewvc/openoffice/trunk/main/
> contains an "ooxml" directory with the problematic files;
> https://svn.apache.org/viewvc/openoffice/branches/AOO410/main/
> does not contain that subdirectory at all, so it does not contain the
> problem.
>

Oh my goodness, you are absolutely correct!  Obviously this can not be a
release blocker if the area does not even exist. I will change the flag.


> Well, fortunately we now have a buildbot that performs a nightly RAT scan
> on AOO410 at https://ci.apache.org/builders/openoffice-linux64-rat-aoo410/
> so (after some initial setup issues are fixed: they are responsible for the
> failures you see) we will all have the RAT output visible on the web and we
> will agree!
>
> If RAT scan passes on AOO410, then the patch does not need porting to
> AOO410 and can't be a blocker for 4.1.2. Any problems found by RAT on
> AOO410 are, instead, blockers for 4.1.2 and need to be reported and
> nominated. I'll wait for a RAT output that we can all see and agree upon
> before commenting in the issue.
>
> Regards,
>   Andrea.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
>


-- 
-------------------------------------------------------------------------------------------------
MzK

"Way down deep, we're all motivated by
 the  same urges.  Cats have the courage
 to live by them."
                        -- Jim Davis

Re: 4.1.2_release_blocker requested: [Issue 126401] Add ASF license headers to files

Posted by Marcus <ma...@wtnet.de>.
Am 07/18/2015 10:24 PM, schrieb Andrea Pescetti:
> jan i wrote:
>> On 18 July 2015 at 00:00, Andrea Pescetti wrote:
>>> I'll wait for a RAT output that we can all see and agree upon
>>> before commenting in the issue.
>> I am lost in all these branches and tags, but I have one position, we run
>> rat scan on the release candidate and any problems is the same as a no-go
>
> Even better: as discussed in other threads on this list, we now have a
> buildbot that will run RAT nightly on the 4.1.2 code (branch AOO410) at
> https://ci.apache.org/builders/openoffice-linux64-rat-aoo410/
> and it produces an output that is there for all of us to see and agree
> upon.
>
> This RAT scan now passes, so we are all happy now, and another important
> step towards the release is done and automated for future commits.

Gavin, thanks a lot. With this we have a critial problem less.

Marcus


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: 4.1.2_release_blocker requested: [Issue 126401] Add ASF license headers to files

Posted by Andrea Pescetti <pe...@apache.org>.
jan i wrote:
> On 18 July 2015 at 00:00, Andrea Pescetti wrote:
>> I'll wait for a RAT output that we can all see and agree upon
>> before commenting in the issue.
> I am lost in all these branches and tags, but I have one position, we run
> rat scan on the release candidate and any problems is the same as a no-go

Even better: as discussed in other threads on this list, we now have a 
buildbot that will run RAT nightly on the 4.1.2 code (branch AOO410) at
https://ci.apache.org/builders/openoffice-linux64-rat-aoo410/
and it produces an output that is there for all of us to see and agree upon.

This RAT scan now passes, so we are all happy now, and another important 
step towards the release is done and automated for future commits.

Regards,
   Andrea.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: 4.1.2_release_blocker requested: [Issue 126401] Add ASF license headers to files

Posted by jan i <ja...@apache.org>.
On 18 July 2015 at 00:00, Andrea Pescetti <pe...@apache.org> wrote:

> On 16/07/2015 bugzilla wrote:
>
>> Kay has asked for 4.1.2_release_blocker:
>> Issue 126401: Add ASF license headers to files
>> https://bz.apache.org/ooo/show_bug.cgi?id=126401
>>
>
> Unless I'm really mistaken this does not apply to AOO410: those files do
> not exist in AOO410, as I wrote yesterday. But Kay is the third person
> mentioning this issue after Jan and Marcus, so if I am the one who is wrong
> just show me the path on AOO410 where the patch should be applied and I'll
> definitely take a look.
>
> What I see is:
> https://svn.apache.org/viewvc/openoffice/trunk/main/
> contains an "ooxml" directory with the problematic files;
> https://svn.apache.org/viewvc/openoffice/branches/AOO410/main/
> does not contain that subdirectory at all, so it does not contain the
> problem.
>
> Well, fortunately we now have a buildbot that performs a nightly RAT scan
> on AOO410 at https://ci.apache.org/builders/openoffice-linux64-rat-aoo410/
> so (after some initial setup issues are fixed: they are responsible for the
> failures you see) we will all have the RAT output visible on the web and we
> will agree!
>
> If RAT scan passes on AOO410, then the patch does not need porting to
> AOO410 and can't be a blocker for 4.1.2. Any problems found by RAT on
> AOO410 are, instead, blockers for 4.1.2 and need to be reported and
> nominated. I'll wait for a RAT output that we can all see and agree upon
> before commenting in the issue.
>

I am lost in all these branches and tags, but I have one position, we run
rat scan on the release candidate and any problems is the same as a no-go
for release. If rat-scan is clean, whether or not these files are includes
I am happy and so it the legal side of apache.

rgds
jan I.


>
> Regards,
>   Andrea.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
>

Re: 4.1.2_release_blocker requested: [Issue 126401] Add ASF license headers to files

Posted by Andrea Pescetti <pe...@apache.org>.
On 16/07/2015 bugzilla wrote:
> Kay has asked for 4.1.2_release_blocker:
> Issue 126401: Add ASF license headers to files
> https://bz.apache.org/ooo/show_bug.cgi?id=126401

Unless I'm really mistaken this does not apply to AOO410: those files do 
not exist in AOO410, as I wrote yesterday. But Kay is the third person 
mentioning this issue after Jan and Marcus, so if I am the one who is 
wrong just show me the path on AOO410 where the patch should be applied 
and I'll definitely take a look.

What I see is:
https://svn.apache.org/viewvc/openoffice/trunk/main/
contains an "ooxml" directory with the problematic files;
https://svn.apache.org/viewvc/openoffice/branches/AOO410/main/
does not contain that subdirectory at all, so it does not contain the 
problem.

Well, fortunately we now have a buildbot that performs a nightly RAT 
scan on AOO410 at 
https://ci.apache.org/builders/openoffice-linux64-rat-aoo410/ so (after 
some initial setup issues are fixed: they are responsible for the 
failures you see) we will all have the RAT output visible on the web and 
we will agree!

If RAT scan passes on AOO410, then the patch does not need porting to 
AOO410 and can't be a blocker for 4.1.2. Any problems found by RAT on 
AOO410 are, instead, blockers for 4.1.2 and need to be reported and 
nominated. I'll wait for a RAT output that we can all see and agree upon 
before commenting in the issue.

Regards,
   Andrea.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org