You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by jm...@apache.org on 2013/05/31 03:18:37 UTC
[2/3] git commit: [flex-sdk] [refs/heads/develop] - Fix for older
version of AIR (including Linux)
Fix for older version of AIR (including Linux)
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f0e7a947
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f0e7a947
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f0e7a947
Branch: refs/heads/develop
Commit: f0e7a947e2e9d36e08b276d7712b75e975713655
Parents: dd14ffc
Author: Justin Mclean <jm...@apache.org>
Authored: Fri May 31 11:17:55 2013 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Fri May 31 11:17:55 2013 +1000
----------------------------------------------------------------------
.../airspark/src/spark/components/Window.as | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f0e7a947/frameworks/projects/airspark/src/spark/components/Window.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/airspark/src/spark/components/Window.as b/frameworks/projects/airspark/src/spark/components/Window.as
index cc7db12..725c3cf 100644
--- a/frameworks/projects/airspark/src/spark/components/Window.as
+++ b/frameworks/projects/airspark/src/spark/components/Window.as
@@ -1774,7 +1774,8 @@ public class Window extends SkinnableContainer implements IWindow
init.type = _type;
init.systemChrome = _systemChrome;
init.transparent = _transparent;
- init.renderMode = _renderMode;
+ if (init.hasOwnProperty("renderMode"))
+ init["renderMode"] = _renderMode;
return init;
}
Re: [2/3] git commit: [flex-sdk] [refs/heads/develop] - Fix for
older version of AIR (including Linux)
Posted by Alex Harui <ah...@adobe.com>.
Minor nit: I think at one point we were told to use "in" instead of
hasOwnProperty for non-dynamic instances, e.g. if ("renderMode" in init)
On 5/30/13 6:18 PM, "jmclean@apache.org" <jm...@apache.org> wrote:
>Fix for older version of AIR (including Linux)
>
>
>Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f0e7a947
>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f0e7a947
>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f0e7a947
>
>Branch: refs/heads/develop
>Commit: f0e7a947e2e9d36e08b276d7712b75e975713655
>Parents: dd14ffc
>Author: Justin Mclean <jm...@apache.org>
>Authored: Fri May 31 11:17:55 2013 +1000
>Committer: Justin Mclean <jm...@apache.org>
>Committed: Fri May 31 11:17:55 2013 +1000
>
>----------------------------------------------------------------------
> .../airspark/src/spark/components/Window.as | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f0e7a947/frameworks/p
>rojects/airspark/src/spark/components/Window.as
>----------------------------------------------------------------------
>diff --git a/frameworks/projects/airspark/src/spark/components/Window.as
>b/frameworks/projects/airspark/src/spark/components/Window.as
>index cc7db12..725c3cf 100644
>--- a/frameworks/projects/airspark/src/spark/components/Window.as
>+++ b/frameworks/projects/airspark/src/spark/components/Window.as
>@@ -1774,7 +1774,8 @@ public class Window extends SkinnableContainer
>implements IWindow
> init.type = _type;
> init.systemChrome = _systemChrome;
> init.transparent = _transparent;
>- init.renderMode = _renderMode;
>+ if (init.hasOwnProperty("renderMode"))
>+ init["renderMode"] = _renderMode;
> return init;
> }
>
>
Re: [2/3] git commit: [flex-sdk] [refs/heads/develop] - Fix for
older version of AIR (including Linux)
Posted by Alex Harui <ah...@adobe.com>.
Minor nit: I think at one point we were told to use "in" instead of
hasOwnProperty for non-dynamic instances, e.g. if ("renderMode" in init)
On 5/30/13 6:18 PM, "jmclean@apache.org" <jm...@apache.org> wrote:
>Fix for older version of AIR (including Linux)
>
>
>Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f0e7a947
>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f0e7a947
>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f0e7a947
>
>Branch: refs/heads/develop
>Commit: f0e7a947e2e9d36e08b276d7712b75e975713655
>Parents: dd14ffc
>Author: Justin Mclean <jm...@apache.org>
>Authored: Fri May 31 11:17:55 2013 +1000
>Committer: Justin Mclean <jm...@apache.org>
>Committed: Fri May 31 11:17:55 2013 +1000
>
>----------------------------------------------------------------------
> .../airspark/src/spark/components/Window.as | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f0e7a947/frameworks/p
>rojects/airspark/src/spark/components/Window.as
>----------------------------------------------------------------------
>diff --git a/frameworks/projects/airspark/src/spark/components/Window.as
>b/frameworks/projects/airspark/src/spark/components/Window.as
>index cc7db12..725c3cf 100644
>--- a/frameworks/projects/airspark/src/spark/components/Window.as
>+++ b/frameworks/projects/airspark/src/spark/components/Window.as
>@@ -1774,7 +1774,8 @@ public class Window extends SkinnableContainer
>implements IWindow
> init.type = _type;
> init.systemChrome = _systemChrome;
> init.transparent = _transparent;
>- init.renderMode = _renderMode;
>+ if (init.hasOwnProperty("renderMode"))
>+ init["renderMode"] = _renderMode;
> return init;
> }
>
>