[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1223: [CELEBORN-290] optimize flink-plugin RemoteShuffleOutputGate/RemoteShuffleResultPartition

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on code in PR #1223:
URL: https://github.com/apache/incubator-celeborn/pull/1223#discussion_r1104063296


##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/buffer/BufferPacker.java:
##########
@@ -81,16 +89,35 @@ public void process(Buffer buffer, int subIdx) throws InterruptedException {
                 buffer.asByteBuf(),
                 BufferUtils.HEADER_LENGTH_PREFIX,
                 buffer.readableBytes() - BufferUtils.HEADER_LENGTH_PREFIX);
+        logger.debug(

Review Comment:
   4 parameters given but only 3 placeholder.



##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/buffer/BufferPacker.java:
##########
@@ -81,16 +89,35 @@ public void process(Buffer buffer, int subIdx) throws InterruptedException {
                 buffer.asByteBuf(),
                 BufferUtils.HEADER_LENGTH_PREFIX,
                 buffer.readableBytes() - BufferUtils.HEADER_LENGTH_PREFIX);
+        logger.debug(
+            "cachedBuffer pack partition:{} type:{}, length:{}",
+            currentSubIdx,
+            buffer.getDataType(),
+            buffer.getSize(),
+            buffer.readableBytes() - BufferUtils.HEADER_LENGTH_PREFIX);
+
         buffer.recycleBuffer();
       } else {
         Buffer dumpedBuffer = cachedBuffer;
         cachedBuffer = buffer;
+        logger.debug(

Review Comment:
   can we implements one method to reduce code for same logging pattern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org