You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/23 14:23:45 UTC

[GitHub] [spark] maropu commented on pull request #31927: [SPARK-34822][SQL] Update the plan stability golden files even if only the explain.txt changes

maropu commented on pull request #31927:
URL: https://github.com/apache/spark/pull/31927#issuecomment-804944559


   We need the two files (`explain.txt` an `simplified.txt`) for tracking plan changes? If the updates of `explain.txt` is less frequently, I think its okay just to keep that file only (drop `simplified.txt`). Anyway, its fine to merge this and see how frequently it is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org