You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/09/02 16:43:59 UTC

Review Request 25251: Property: javax.jdo.option.ConnectionPassword is absent in hive-site.xml.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25251/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-7113
    https://issues.apache.org/jira/browse/AMBARI-7113


Repository: ambari


Description
-------

Precondition:  
Deploy cluster with all components and default settings.

STR:  
1) Navigate on Services->HIVE tab  
2) Click Download Client Configs and download file  
3)Check hive-site.xml files at cluster and in downloaded files.  
/etc/hive/conf.dist/hive-site.xml

Expected result:  
Files have same values. Property: javax.jdo.option.ConnectionPassword present
in host (hive-site.xml) and downloaded(hive-site.xml) files.

Actual result:  
Property: javax.jdo.option.ConnectionPassword is **present** in Download
Client Configs files and **absent** in hive-site.xml.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e5b6016 

Diff: https://reviews.apache.org/r/25251/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 25251: Property: javax.jdo.option.ConnectionPassword is absent in hive-site.xml.

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25251/#review52029
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
<https://reviews.apache.org/r/25251/#comment90740>

    Any unit tests ? It shouldn't be difficult.


- Dmytro Sen


On Сен. 2, 2014, 2:43 п.п., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25251/
> -----------------------------------------------------------
> 
> (Updated Сен. 2, 2014, 2:43 п.п.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-7113
>     https://issues.apache.org/jira/browse/AMBARI-7113
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Precondition:  
> Deploy cluster with all components and default settings.
> 
> STR:  
> 1) Navigate on Services->HIVE tab  
> 2) Click Download Client Configs and download file  
> 3)Check hive-site.xml files at cluster and in downloaded files.  
> /etc/hive/conf.dist/hive-site.xml
> 
> Expected result:  
> Files have same values. Property: javax.jdo.option.ConnectionPassword present
> in host (hive-site.xml) and downloaded(hive-site.xml) files.
> 
> Actual result:  
> Property: javax.jdo.option.ConnectionPassword is **present** in Download
> Client Configs files and **absent** in hive-site.xml.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java e5b6016 
> 
> Diff: https://reviews.apache.org/r/25251/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>