You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Alexey Diomin (JIRA)" <ji...@apache.org> on 2010/07/09 12:34:50 UTC
[jira] Created: (HIVE-1456) potencail NullPointerException
potencail NullPointerException
------------------------------
Key: HIVE-1456
URL: https://issues.apache.org/jira/browse/HIVE-1456
Project: Hadoop Hive
Issue Type: Improvement
Components: Query Processor
Reporter: Alexey Diomin
Priority: Trivial
Fix For: 0.5.1
in ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java not check input arguments on null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1456) potentail NullPointerException
Posted by "Alexey Diomin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887296#action_12887296 ]
Alexey Diomin commented on HIVE-1456:
-------------------------------------
why we then check null on row 147 if LOG always not null ?
> potentail NullPointerException
> ------------------------------
>
> Key: HIVE-1456
> URL: https://issues.apache.org/jira/browse/HIVE-1456
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Alexey Diomin
> Priority: Trivial
> Fix For: 0.5.1
>
> Attachments: HIVE-1456.patch
>
>
> in ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java not check input arguments on null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1456) potentail NullPointerException
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886785#action_12886785 ]
He Yongqiang commented on HIVE-1456:
------------------------------------
Alexey, the only caller of initializeMapredLocalWork is initializeLocalWork() in the same class, and the caller passed a LOG which is always not null.
why do you see it can potentially cause null pointer?
> potentail NullPointerException
> ------------------------------
>
> Key: HIVE-1456
> URL: https://issues.apache.org/jira/browse/HIVE-1456
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Alexey Diomin
> Priority: Trivial
> Fix For: 0.5.1
>
> Attachments: HIVE-1456.patch
>
>
> in ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java not check input arguments on null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1456) potentail NullPointerException
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887431#action_12887431 ]
He Yongqiang commented on HIVE-1456:
------------------------------------
Thanks. The check in line 147 is not needed. We can remove it. Alexey, can you update your patch to remove the check in line 147?
> potentail NullPointerException
> ------------------------------
>
> Key: HIVE-1456
> URL: https://issues.apache.org/jira/browse/HIVE-1456
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Alexey Diomin
> Priority: Trivial
> Fix For: 0.5.1
>
> Attachments: HIVE-1456.patch
>
>
> in ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java not check input arguments on null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1456) potentail NullPointerException
Posted by "Alexey Diomin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Diomin updated HIVE-1456:
--------------------------------
Attachment: HIVE-1456-1.patch
remove check in line 147
> potentail NullPointerException
> ------------------------------
>
> Key: HIVE-1456
> URL: https://issues.apache.org/jira/browse/HIVE-1456
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Alexey Diomin
> Priority: Trivial
> Fix For: 0.5.1
>
> Attachments: HIVE-1456-1.patch, HIVE-1456.patch
>
>
> in ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java not check input arguments on null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1456) potentail NullPointerException
Posted by "Alexey Diomin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Diomin updated HIVE-1456:
--------------------------------
Summary: potentail NullPointerException (was: potencail NullPointerException)
> potentail NullPointerException
> ------------------------------
>
> Key: HIVE-1456
> URL: https://issues.apache.org/jira/browse/HIVE-1456
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Alexey Diomin
> Priority: Trivial
> Fix For: 0.5.1
>
>
> in ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java not check input arguments on null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1456) potentail NullPointerException
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1456:
---------------------------------
Fix Version/s: (was: 0.5.1)
> potentail NullPointerException
> ------------------------------
>
> Key: HIVE-1456
> URL: https://issues.apache.org/jira/browse/HIVE-1456
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Alexey Diomin
> Priority: Trivial
> Attachments: HIVE-1456-1.patch, HIVE-1456.patch
>
>
> in ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java not check input arguments on null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1456) potentail NullPointerException
Posted by "Alexey Diomin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Diomin updated HIVE-1456:
--------------------------------
Attachment: HIVE-1456.patch
trivial fix
> potentail NullPointerException
> ------------------------------
>
> Key: HIVE-1456
> URL: https://issues.apache.org/jira/browse/HIVE-1456
> Project: Hadoop Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Alexey Diomin
> Priority: Trivial
> Fix For: 0.5.1
>
> Attachments: HIVE-1456.patch
>
>
> in ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java not check input arguments on null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.