[GitHub] flink pull request #2870: [FLINK-4565] Support for SQL IN operator

[twalthr <gi...@git.apache.org>]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2870#discussion_r94808082
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/calls/ScalarOperators.scala ---
    @@ -79,6 +79,72 @@ object ScalarOperators {
         }
       }
     
    +  def generateIn(
    +      nullCheck: Boolean,
    +      left: GeneratedExpression,
    --- End diff --
    
    Could you come up with a name for the parameters `left` and `right` (e.g. `needle`, `haystack`)? It is difficult to read otherwise; also at other locations in the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---