You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/03/02 09:43:39 UTC
[GitHub] [maven] cstamas opened a new pull request, #1026: [MNG-6889] Big fat warning on llr
cstamas opened a new pull request, #1026:
URL: https://github.com/apache/maven/pull/1026
This option promotes "Maven2" in latest Maven 3 versions that is insane. Also, this option was really meant to bridge transition from Maven2 to Maven3, when both were sharing same local repository. Hopefully, in 2023 nobody does that anymore.
---
https://issues.apache.org/jira/browse/MNG-6889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #1026: [3.8.x] [MNG-6889] Deprecate llr option
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #1026:
URL: https://github.com/apache/maven/pull/1026#discussion_r1122851290
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -241,6 +241,12 @@ private void setUpLocalRepositoryManager( MavenExecutionRequest request, Default
session.setLocalRepositoryManager( simpleLocalRepoMgrFactory.newInstance( session, localRepo ) );
logger.info( "Disabling enhanced local repository: using legacy is strongly discouraged to ensure"
+ " build reproducibility." );
+ logger.warn( "" );
+ logger.warn( "WARNING: due issues listed above, but also due fact that with this option" );
Review Comment:
Sentence here, start upper case.
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -241,6 +241,12 @@ private void setUpLocalRepositoryManager( MavenExecutionRequest request, Default
session.setLocalRepositoryManager( simpleLocalRepoMgrFactory.newInstance( session, localRepo ) );
logger.info( "Disabling enhanced local repository: using legacy is strongly discouraged to ensure"
+ " build reproducibility." );
+ logger.warn( "" );
+ logger.warn( "WARNING: due issues listed above, but also due fact that with this option" );
Review Comment:
The warning is a duplicate.
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -241,6 +241,12 @@ private void setUpLocalRepositoryManager( MavenExecutionRequest request, Default
session.setLocalRepositoryManager( simpleLocalRepoMgrFactory.newInstance( session, localRepo ) );
logger.info( "Disabling enhanced local repository: using legacy is strongly discouraged to ensure"
+ " build reproducibility." );
+ logger.warn( "" );
+ logger.warn( "WARNING: due issues listed above, but also due fact that with this option" );
+ logger.warn( "Maven cannot provide the latest local repository features, it is being " );
+ logger.warn( "DEPRECATED. Moreover, this option is being DROPPED starting with Maven 3.9.1, and use" );
Review Comment:
Move "DEPRECATED" up a line
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -241,6 +241,12 @@ private void setUpLocalRepositoryManager( MavenExecutionRequest request, Default
session.setLocalRepositoryManager( simpleLocalRepoMgrFactory.newInstance( session, localRepo ) );
logger.info( "Disabling enhanced local repository: using legacy is strongly discouraged to ensure"
+ " build reproducibility." );
+ logger.warn( "" );
+ logger.warn( "WARNING: due issues listed above, but also due fact that with this option" );
+ logger.warn( "Maven cannot provide the latest local repository features, it is being " );
Review Comment:
Trailing space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas merged pull request #1026: [3.8.x] [MNG-6889] Deprecate llr option
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1026:
URL: https://github.com/apache/maven/pull/1026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org