You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mark Struberg (Created) (JIRA)" <de...@myfaces.apache.org> on 2011/10/24 11:21:32 UTC
[jira] [Created] (MYFACES-3368) enable 'standard' checkstyle checks
in myfaces-core
enable 'standard' checkstyle checks in myfaces-core
---------------------------------------------------
Key: MYFACES-3368
URL: https://issues.apache.org/jira/browse/MYFACES-3368
Project: MyFaces Core
Issue Type: Improvement
Affects Versions: 2.1.3
Reporter: Mark Struberg
Assignee: Mark Struberg
We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Michael Kurz (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133963#comment-13133963 ]
Michael Kurz commented on MYFACES-3368:
---------------------------------------
Btw.: Is [1] really the only and definite source for MyFaces code style? I recently had a look at the guidelines and then at some MyFaces code. There was not much compliance especially regarding new lines before and after braces and stuff like that.
Maybe we should clarify this and update the wiki accordingly (unless I missed the 'true' source).
[1]: https://cwiki.apache.org/MYFACES/myfaces-developer-notes.html
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (MYFACES-3368) enable 'standard'
checkstyle checks in myfaces-core
Posted by "Bernd Bohmann (Issue Comment Edited) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133946#comment-13133946 ]
Bernd Bohmann edited comment on MYFACES-3368 at 10/24/11 9:56 AM:
------------------------------------------------------------------
Why do you think they are archaic I agree with most of the stuff?
was (Author: bommel):
Why do you think the are archaic I agree with most of the stuff?
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Mark Struberg (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133947#comment-13133947 ]
Mark Struberg commented on MYFACES-3368:
----------------------------------------
Just as an explanation about _why_ I'm so picky about it.
I now need to get the myfaces-commons-resourcehandler running in my project. And while testing it, I found out that there are quite a few bugs caused by
> if (..)
> bums();
> dings();
which of course always executes dings()
and particularry funny was
> while(..);
> {
> doSomething();
> }
which always executed doSomething() just once...
Both got correctly reported as error by our standard checkstyle rules. Having empty statements is just bad as is having if-statements without bracelets...
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Mark Struberg (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133943#comment-13133943 ]
Mark Struberg commented on MYFACES-3368:
----------------------------------------
the sun conventions are 12 years old and partly archaic or even obsolete.
In fact the _ in front of variable names must (according to lots of sources) only be allowed for private members at best. The benefit is also questionable, but I guess it's ok to keep this old habit. But I've seen local variables and even method parameters wich _variable! This is just plain wrong (and ever was).
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Mark Struberg (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137507#comment-13137507 ]
Mark Struberg commented on MYFACES-3368:
----------------------------------------
Leo, can you please check the following methods heavily exceed the (already extended) line limit for methods (300 LOC) and split them into several smaller chunks?
AnnotationConfigurator#createFacesConfig
ComponentTagHandlerDelegate#apply
FaceletViewDeclarationLanguage#retargetMethodExpressions
I think it's better if you do that because you are way more into meaningful details of the code than I am. - txs!
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Bernd Bohmann (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133946#comment-13133946 ]
Bernd Bohmann commented on MYFACES-3368:
----------------------------------------
Why do you think the are archaic I agree with most of the stuff?
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Bernd Bohmann (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133950#comment-13133950 ]
Bernd Bohmann commented on MYFACES-3368:
----------------------------------------
I agree with enforcing braces and other things
The tobago checkstyle rules are more strict than the 'standard' rules but if someone force me to use '_ ' for variable name in tobago i will stop my work.
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (MYFACES-3368) enable 'standard'
checkstyle checks in myfaces-core
Posted by "Bernd Bohmann (Issue Comment Edited) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133941#comment-13133941 ]
Bernd Bohmann edited comment on MYFACES-3368 at 10/24/11 9:52 AM:
------------------------------------------------------------------
Are you sure that are the 'standard' myfaces rules?
was (Author: bommel):
Are you care that are the 'standard' myfaces rules?
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (MYFACES-3368) enable 'standard'
checkstyle checks in myfaces-core
Posted by "Bernd Bohmann (Issue Comment Edited) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133950#comment-13133950 ]
Bernd Bohmann edited comment on MYFACES-3368 at 10/24/11 10:01 AM:
-------------------------------------------------------------------
I agree with enforcing braces and other things
The tobago checkstyle rules are more strict than the 'standard' rules but if someone force me to use '_ ' for a variable name in tobago i will stop my work.
was (Author: bommel):
I agree with enforcing braces and other things
The tobago checkstyle rules are more strict than the 'standard' rules but if someone force me to use '_ ' for variable name in tobago i will stop my work.
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Mark Struberg (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133937#comment-13133937 ]
Mark Struberg commented on MYFACES-3368:
----------------------------------------
svn co https://svn.apache.org/repos/asf/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/
the files get packages as standard resources and then accessed as such via the maven-checkstyle-plugin.
The files in question can be found here:
https://svn.apache.org/repos/asf/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/default/
It seems tobago has it's own set of rules:
https://svn.apache.org/repos/asf/myfaces/myfaces-build-tools/trunk/other/checkstyle-rules/src/main/resources/tobago/
Bernd, can you please go on and test the upgrade to mf-parent-11-SNAPSHOT in tobago?
You should drop the version of the maven-checkstyle-plugin from your pom to get the latest version defined in mf-parent.
There have been some changes in the checkstyle syntax, thus you maybe need some minor tweeks to make it work. Ping me if you need help. txs!
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Mark Struberg (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134930#comment-13134930 ]
Mark Struberg commented on MYFACES-3368:
----------------------------------------
Leo,
I now finished the myfaces-core-api cleanup. There are now 7 checkstyle errors left in this module. I looked at them, but I'm honestly not sure if you would like the fix I would apply ;) Thus, can you please take a look yourself?
There are a few complicated inner assignments and a few 'equals without hashCode'.
You can build myfaces-core with
%:> mvn clean install -Pcheckstyle
or if you only like to generate the checkstyle report alone:
%:> mvn checkstyle:check -Pcheckstyle
The checkstyle-report itself is available at
%:> less target/checkstyle-result.xml
txs and LieGrue,
strub
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Mark Struberg (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133964#comment-13133964 ]
Mark Struberg commented on MYFACES-3368:
----------------------------------------
Yes, absolutely!
I came across this wiki page too and was hmm a bit surprised. I tried to import the IDEA checkstyle definition and got an error. Then I figured that it was made for IDEA-7.x ^^ So yes, this needs an update too I fear ;)
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Michael Kurz (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133973#comment-13133973 ]
Michael Kurz commented on MYFACES-3368:
---------------------------------------
Yes, it didn't work for me too on IDEA 10.5.
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Bernd Bohmann (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133936#comment-13133936 ]
Bernd Bohmann commented on MYFACES-3368:
----------------------------------------
please look at http://wiki.apache.org/myfaces/MyFaces_Developer_Notes
http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html
the 'standard' myfaces rules are not compatible with the 'Code Conventions for the Java TM Programming Language'
for example Variable names should not start with underscore _ ..
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Bernd Bohmann (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133924#comment-13133924 ]
Bernd Bohmann commented on MYFACES-3368:
----------------------------------------
what are the 'standard' myfaces rules?
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Leonardo Uribe (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147411#comment-13147411 ]
Leonardo Uribe commented on MYFACES-3368:
-----------------------------------------
Fixed almost all checkstyle rules on shared module. The only one I can't fix is some methods on HtmlRendererUtils that has more than 10 parameters.
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Leonardo Uribe
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Leonardo Uribe (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138042#comment-13138042 ]
Leonardo Uribe commented on MYFACES-3368:
-----------------------------------------
Ok, no problem, but give me some time, I want to commit MYFACES-3259 first and this patch changes ComponentTagHandlerDelegate#apply. The one I really don't want to change is FaceletViewDeclarationLanguage#retargetMethodExpressions, because it is a difficult algorithm and have it as is makes easier read it and update it. But I have lots of junit tests for that one, so after all it is ok to refactor it.
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Leonardo Uribe
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Mark Struberg (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134783#comment-13134783 ]
Mark Struberg commented on MYFACES-3368:
----------------------------------------
I know Leo, but somewhen we had to do it.
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Leonardo Uribe (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135166#comment-13135166 ]
Leonardo Uribe commented on MYFACES-3368:
-----------------------------------------
I checked them and fix the checkstyle errors is ok.
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Leonardo Uribe (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134750#comment-13134750 ]
Leonardo Uribe commented on MYFACES-3368:
-----------------------------------------
Just one comment: apply this checkstyle will make harder keep in sync 2.0.x branch, because it mess up almost all files. Now, to apply a patch in both branches it is required to rewrite some parts and a svn merge from 2.0.x to 2.1.x will not work well. The right way to do it is apply on 2.0.x first and then on 2.1.x. Inclusive, there are some parts that change java api signature, introducing bugs on the TCK. By that reason, I'm forced to check every single file it was committed, wasting a lot of time. Please be more careful next time.
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Bernd Bohmann (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133941#comment-13133941 ]
Bernd Bohmann commented on MYFACES-3368:
----------------------------------------
Are you care that are the 'standard' myfaces rules?
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Mark Struberg (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133948#comment-13133948 ]
Mark Struberg commented on MYFACES-3368:
----------------------------------------
Bernd, if there is some particular check which you cannot live with then just tell us and we do discuss the pros and cons (and eventually just disabling or differently configuring this very check).
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3368) enable 'standard' checkstyle
checks in myfaces-core
Posted by "Mark Struberg (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133954#comment-13133954 ]
Mark Struberg commented on MYFACES-3368:
----------------------------------------
> but if someone force me to use '_ ' for variable name in tobago i will stop my work.
hehe au contraire - no worries, it's exactly the other way around :)
Currently we have a lot of code which uses _variableName even for method parameters and local method variables.
This is just plain ugly and wrong - and our standard checkstyle rules even raise this as an error! So no worries, NOT writing _ will always work, but using _variableName is only allowed for class members (again, you _can_ use it but you don't need to).
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
> Key: MYFACES-3368
> URL: https://issues.apache.org/jira/browse/MYFACES-3368
> Project: MyFaces Core
> Issue Type: Improvement
> Affects Versions: 2.1.3
> Reporter: Mark Struberg
> Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take some time to fix (found 1111 errors only in the first module).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira