[jira] [Comment Edited] (IGNITE-6565) Use long type for size and keySize in cache metrics

["Anton Vinogradov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-6565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447850#comment-16447850 ] 

Anton Vinogradov edited comment on IGNITE-6565 at 4/23/18 9:43 AM:
-------------------------------------------------------------------

[~sharpler], 

1) I do not like the design. 
*long() method is a bad case.
Lets add {{getCache*()}} methods, like {{getCacheHits()}} we already have.
Also, we should mark {{getSize()}} and {{getKeySize()}} as Deprecated 

2) Another proposal is to deprecate {{getKeySize}} instead of creading new {{getCacheKeySize}}.
Please check it's suitable solution.


was (Author: avinogradov):
[~sharpler], 

I do not like the design. 
*long() method is a bad case.
Lets add {{getCache*()}} methods, like {{getCacheHits()}} we already have.
Also, we should mark {{getSize()}} and {{getKeySize()}} as Deprecated 

> Use long type for size and keySize in cache metrics
> ---------------------------------------------------
>
>                 Key: IGNITE-6565
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6565
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.2
>            Reporter: Ilya Kasnacheev
>            Assignee: Alexander Menshikov
>            Priority: Major
>              Labels: easyfix
>
> Currently it's int so for large caches there's no way to convey correct value.
> Should introduce getSizeLong() and getKeySizeLong()
> Also introduce the same in .Net and make sure that compatibility not broken when passing OP_LOCAL_METRICS and OP_GLOBAL_METRICS.
> BTW do we need keySize at all? What's it for?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)