[GitHub] [arrow-datafusion] jorgecarleitao commented on a change in pull request #524: [Python] Expose ExecutionContext.register_csv

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #524:
URL: https://github.com/apache/arrow-datafusion/pull/524#discussion_r647525460



##########
File path: python/src/context.rs
##########
@@ -97,6 +99,34 @@ impl ExecutionContext {
         Ok(())
     }
 
+    #[args(
+        has_header = "true",
+        delimiter = "b\",\"",
+        schema_infer_max_records = "1000",
+        file_extension = "\".csv\""
+    )]
+    fn register_csv(
+        &mut self,
+        name: &str,
+        path: &str,
+        has_header: bool,
+        delimiter: &[u8],

Review comment:
       I agree. I only learnt that the Schema and DataType have a c data interface recently. This likely requires some refactoring on the arrow-rs, as it assumes that metadata do not require a specific in-memory alignment, and yet the c data interface makes such requirement.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org