[GitHub] [airflow] dstandish commented on pull request #27559: Generic RDS Operators

[GitBox <gi...@apache.org>]

dstandish commented on PR #27559:
URL: https://github.com/apache/airflow/pull/27559#issuecomment-1307711218

   It's an interesting idea
   
   I wonder if it might be better to just make one operator that can do many things, and control the behavior with an enum.
   
   E.g. `GenericRdsOperator`
   
   and 
   
   ```
   class RdsAction(str, Enum):
       describe_instances = 'describe_instances'
       ...
   ```
   
   then
   
   ```
   op =  GenericRdsOperator(action=RdsAction.describe_instances)
   ```
   
   all of your subclasses don't do anything except change one parameter, so it seems that subclass may be overkill here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org