You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "Aman-Mittal (via GitHub)" <gi...@apache.org> on 2026/01/10 13:30:10 UTC
[PR] FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 5) [fineract]
Aman-Mittal opened a new pull request, #5311:
URL: https://github.com/apache/fineract/pull/5311
## Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
- [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 5) [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #5311:
URL: https://github.com/apache/fineract/pull/5311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 5) [fineract]
Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal commented on code in PR #5311:
URL: https://github.com/apache/fineract/pull/5311#discussion_r2693348684
##########
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/domain/Charge.java:
##########
@@ -755,23 +710,14 @@ public boolean isDisbursementCharge() {
|| ChargeTimeType.fromInt(this.chargeTimeType).equals(ChargeTimeType.TRANCHE_DISBURSEMENT);
}
- public TaxGroup getTaxGroup() {
- return this.taxGroup;
- }
-
- public void setTaxGroup(TaxGroup taxGroup) {
- this.taxGroup = taxGroup;
- }
-
@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}
- if (!(o instanceof Charge)) {
+ if (!(o instanceof Charge other)) {
return false;
}
- Charge other = (Charge) o;
Review Comment:
Putting this in draft for conflict resolution, meanwhile for this change i will reverting this logic back for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 5) [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5311:
URL: https://github.com/apache/fineract/pull/5311#discussion_r2682233505
##########
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/domain/Charge.java:
##########
@@ -755,23 +710,14 @@ public boolean isDisbursementCharge() {
|| ChargeTimeType.fromInt(this.chargeTimeType).equals(ChargeTimeType.TRANCHE_DISBURSEMENT);
}
- public TaxGroup getTaxGroup() {
- return this.taxGroup;
- }
-
- public void setTaxGroup(TaxGroup taxGroup) {
- this.taxGroup = taxGroup;
- }
-
@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}
- if (!(o instanceof Charge)) {
+ if (!(o instanceof Charge other)) {
return false;
}
- Charge other = (Charge) o;
Review Comment:
Rename the `o` argument to `other`, if you want to work with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 5) [fineract]
Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal commented on PR #5311:
URL: https://github.com/apache/fineract/pull/5311#issuecomment-3785221174
@adamsaghy Please review if any other change is required or not, I have reverted the pattern matching code implementation as i will plan this after more research.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 5) [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5311:
URL: https://github.com/apache/fineract/pull/5311#discussion_r2682233505
##########
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/domain/Charge.java:
##########
@@ -755,23 +710,14 @@ public boolean isDisbursementCharge() {
|| ChargeTimeType.fromInt(this.chargeTimeType).equals(ChargeTimeType.TRANCHE_DISBURSEMENT);
}
- public TaxGroup getTaxGroup() {
- return this.taxGroup;
- }
-
- public void setTaxGroup(TaxGroup taxGroup) {
- this.taxGroup = taxGroup;
- }
-
@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}
- if (!(o instanceof Charge)) {
+ if (!(o instanceof Charge other)) {
return false;
}
- Charge other = (Charge) o;
Review Comment:
Rename the `o` argument to `other`, if you want to work with. Also you can change the argument type from `Object` to `Charge`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2421: Refractor redundant and some deprecated code as per new Java 21 style (Phase 5) [fineract]
Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal commented on code in PR #5311:
URL: https://github.com/apache/fineract/pull/5311#discussion_r2701264209
##########
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/domain/Charge.java:
##########
@@ -755,23 +710,14 @@ public boolean isDisbursementCharge() {
|| ChargeTimeType.fromInt(this.chargeTimeType).equals(ChargeTimeType.TRANCHE_DISBURSEMENT);
}
- public TaxGroup getTaxGroup() {
- return this.taxGroup;
- }
-
- public void setTaxGroup(TaxGroup taxGroup) {
- this.taxGroup = taxGroup;
- }
-
@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}
- if (!(o instanceof Charge)) {
+ if (!(o instanceof Charge other)) {
return false;
}
- Charge other = (Charge) o;
Review Comment:
Please review again reverted this part of code, will plan this change in upcoming phases of optimizations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org