You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "zhongjiajie (via GitHub)" <gi...@apache.org> on 2024/04/26 03:43:18 UTC
[PR] ci: compatible ruff latest version [dolphinscheduler-sdk-python]
zhongjiajie opened a new pull request, #144:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/144
our ci fail with latest version of ruff in step `lint`
https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/8841147449/job/24277780100
<!--Thanks for you contribute to Apache DolphinScheduler Python API, You can see more detail about contributing in https://github.com/apache/dolphinscheduler-sdk-python/DEVELOP.md .-->
## Brief Summary of The Change
<!--Please include `fixes: #XXXX(ISSUE_NUMBER)` to automatically close any corresponding issue when the pull request is merged. Alternatively if not fully closed you can say `related: #XXXX(ISSUE_NUMBER)`.-->
## Pull Request checklist
I confirm that the following checklist has been completed.
- [x] Add/Change **test cases** for the changes.
- [x] Add/Change the related **documentation**, should also change `docs/source/config.rst` when you change file `default_config.yaml`.
- [x] (Optional) Add your change to `UPDATING.md` when it is an incompatible change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: compatible ruff latest version [dolphinscheduler-sdk-python]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #144:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/144#issuecomment-2078579768
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `54.54545%` with `5 lines` in your changes are missing coverage. Please review.
> Project coverage is 90.88%. Comparing base [(`2f1f2c4`)](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/commit/2f1f2c449f501e2323938c8195255927aeb52cb3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`7818d2e`)](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [src/pydolphinscheduler/core/yaml\_workflow.py](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144?src=pr&el=tree&filepath=src%2Fpydolphinscheduler%2Fcore%2Fyaml_workflow.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb3JlL3lhbWxfd29ya2Zsb3cucHk=) | 66.66% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/pydolphinscheduler/resources\_plugin/github.py](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144?src=pr&el=tree&filepath=src%2Fpydolphinscheduler%2Fresources_plugin%2Fgithub.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9yZXNvdXJjZXNfcGx1Z2luL2dpdGh1Yi5weQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/pydolphinscheduler/resources\_plugin/gitlab.py](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144?src=pr&el=tree&filepath=src%2Fpydolphinscheduler%2Fresources_plugin%2Fgitlab.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9yZXNvdXJjZXNfcGx1Z2luL2dpdGxhYi5weQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 90.88% 90.88%
=======================================
Files 64 64
Lines 2371 2371
=======================================
Hits 2155 2155
Misses 216 216
```
| [Flag](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [unittests](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.88% <54.54%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/144?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: compatible ruff latest version [dolphinscheduler-sdk-python]
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie merged PR #144:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org