You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2017/12/09 22:13:23 UTC
Review Request 64482: Fix flaky WebhookTest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64482/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
I opted for a minimal patch that stays close to the style of the other
tests. There is a remaining risk of a race condition if the OS re-uses
the same port between stopping jetty and triggering the webhooks, but
it should be very unlikely.
Diffs
-----
src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java adeff8939a4c4a225444dc5ca2575f9eb705a92b
Diff: https://reviews.apache.org/r/64482/diff/1/
Testing
-------
Multiple runs of ./gradlew test
Thanks,
Stephan Erb
Re: Review Request 64482: Fix flaky WebhookTest
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64482/#review193338
-----------------------------------------------------------
Ship it!
Master (47c6899) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 9, 2017, 10:13 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64482/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2017, 10:13 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I opted for a minimal patch that stays close to the style of the other
> tests. There is a remaining risk of a race condition if the OS re-uses
> the same port between stopping jetty and triggering the webhooks, but
> it should be very unlikely.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java adeff8939a4c4a225444dc5ca2575f9eb705a92b
>
>
> Diff: https://reviews.apache.org/r/64482/diff/2/
>
>
> Testing
> -------
>
> Multiple runs of ./gradlew test
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 64482: Fix flaky WebhookTest
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64482/#review193337
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On Dec. 9, 2017, 11:13 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64482/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2017, 11:13 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I opted for a minimal patch that stays close to the style of the other
> tests. There is a remaining risk of a race condition if the OS re-uses
> the same port between stopping jetty and triggering the webhooks, but
> it should be very unlikely.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java adeff8939a4c4a225444dc5ca2575f9eb705a92b
>
>
> Diff: https://reviews.apache.org/r/64482/diff/2/
>
>
> Testing
> -------
>
> Multiple runs of ./gradlew test
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 64482: Fix flaky WebhookTest
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64482/#review193336
-----------------------------------------------------------
Ship it!
Master (47c6899) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 9, 2017, 10:13 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64482/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2017, 10:13 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I opted for a minimal patch that stays close to the style of the other
> tests. There is a remaining risk of a race condition if the OS re-uses
> the same port between stopping jetty and triggering the webhooks, but
> it should be very unlikely.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java adeff8939a4c4a225444dc5ca2575f9eb705a92b
>
>
> Diff: https://reviews.apache.org/r/64482/diff/2/
>
>
> Testing
> -------
>
> Multiple runs of ./gradlew test
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 64482: Fix flaky WebhookTest
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64482/#review193335
-----------------------------------------------------------
Master (47c6899) is red with this patch.
./build-support/jenkins/build.sh
[217] ./src/main/js/index.js 3.15 kB {0} [built]
[253] ./~/react-router-dom/es/Redirect.js 137 bytes {0} [built]
+ 262 hidden modules
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:processTestResources
:testClasses
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain
:checkstyleTest[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java:22:8: Unused import - java.util.stream.Stream. [UnusedImports]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleTest'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/test.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 3m 5s
32 actionable tasks: 26 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 9, 2017, 10:13 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64482/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2017, 10:13 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I opted for a minimal patch that stays close to the style of the other
> tests. There is a remaining risk of a race condition if the OS re-uses
> the same port between stopping jetty and triggering the webhooks, but
> it should be very unlikely.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java adeff8939a4c4a225444dc5ca2575f9eb705a92b
>
>
> Diff: https://reviews.apache.org/r/64482/diff/1/
>
>
> Testing
> -------
>
> Multiple runs of ./gradlew test
>
>
> Thanks,
>
> Stephan Erb
>
>