[GitHub] [incubator-nuttx] liuchengvbl opened a new pull request #4572: fix: nxstyle: detect --,->,++ not next to operand

[GitBox <gi...@apache.org>]

liuchengvbl opened a new pull request #4572:
URL: https://github.com/apache/incubator-nuttx/pull/4572


   ## Summary
   The nxstyle check tool can't recongnize the style error that --, -> or ++ is not next to the operand. For example, "idx ++;", "p ->member" or "(-- idx)", which is in incorrect style, is not recongnized. This patch add detection for these cases.
   
   Change-Id: Ic6b71ddeca95db9057b4b707a670891a03b8d6a4
   Signed-off-by: liucheng5 <li...@xiaomi.com>
   
   ## Impact
   tools/checkpatch.sh
   
   ## Testing
   These cases of wrong styles are detected and reported:
   “a ++ + b”
   "a ++;"
   "i ++\n"
   "a[-- i]"
   "while (i --)"
   "p -> member"
   "p ->member"
   "p-> member"
   
   These cases of right styles will not bring an error report:
   "a++ + b"
   "a++;"
   "i++\n"
   "a[--i]"
   “while (i--)”
   “p->member”
   "p->\n
       member"
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan merged pull request #4572: fix: nxstyle: detect --,->,++ not next to operand

[GitBox <gi...@apache.org>]

hartmannathan merged pull request #4572:
URL: https://github.com/apache/incubator-nuttx/pull/4572


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org