You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Brian Whipple (JIRA)" <ji...@apache.org> on 2008/10/21 07:00:44 UTC
[jira] Created: (JCR-1822) Patches for previously incompleted
patches
Patches for previously incompleted patches
------------------------------------------
Key: JCR-1822
URL: https://issues.apache.org/jira/browse/JCR-1822
Project: Jackrabbit
Issue Type: Improvement
Components: jackrabbit-core
Affects Versions: core 1.4.6
Reporter: Brian Whipple
This is a patch to complete two earlier patches that were partially patched.
JCR-1295 contained patch code for MS SqlServer tablespace support for the filesystem and db persistence manager that was not applied. I have cleaned up the submitted code and it should be applied to be consistent.
JCR-1362 was a fix for Oracle schema test that was applied to 1.4 branch from trunk but was incomplete.
This is a single patch for both issues.
The fix for JCR-1362 only requires updating a single file from the patch: src/main/java/org/apache/jackrabbit/core/journal/DatabaseJournal.java
All other files are related to completing JCR-1295.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1822) Patches for previously incompleted
patches
Posted by "Brian Whipple (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Whipple updated JCR-1822:
-------------------------------
Attachment: jackrabbit-core.diff
> Patches for previously incompleted patches
> ------------------------------------------
>
> Key: JCR-1822
> URL: https://issues.apache.org/jira/browse/JCR-1822
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: core 1.4.6
> Reporter: Brian Whipple
> Attachments: jackrabbit-core.diff
>
>
> This is a patch to complete two earlier patches that were partially patched.
> JCR-1295 contained patch code for MS SqlServer tablespace support for the filesystem and db persistence manager that was not applied. I have cleaned up the submitted code and it should be applied to be consistent.
> JCR-1362 was a fix for Oracle schema test that was applied to 1.4 branch from trunk but was incomplete.
> This is a single patch for both issues.
> The fix for JCR-1362 only requires updating a single file from the patch: src/main/java/org/apache/jackrabbit/core/journal/DatabaseJournal.java
> All other files are related to completing JCR-1295.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1822) Patches for previously incompleted
patches
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643157#action_12643157 ]
Thomas Mueller commented on JCR-1822:
-------------------------------------
Hi,
Thanks for the patch, but could you change the title please? Usually the title of an issue says what the change is about. If the patch is for two different things, it makes sense to split the patch. Example:
"MS SQL Server tablespace support"
"DatabaseJournal test case for Oracle"
Regards,
Thomas
> Patches for previously incompleted patches
> ------------------------------------------
>
> Key: JCR-1822
> URL: https://issues.apache.org/jira/browse/JCR-1822
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: core 1.4.6
> Reporter: Brian Whipple
> Attachments: jackrabbit-core.diff
>
>
> This is a patch to complete two earlier patches that were partially patched.
> JCR-1295 contained patch code for MS SqlServer tablespace support for the filesystem and db persistence manager that was not applied. I have cleaned up the submitted code and it should be applied to be consistent.
> JCR-1362 was a fix for Oracle schema test that was applied to 1.4 branch from trunk but was incomplete.
> This is a single patch for both issues.
> The fix for JCR-1362 only requires updating a single file from the patch: src/main/java/org/apache/jackrabbit/core/journal/DatabaseJournal.java
> All other files are related to completing JCR-1295.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (JCR-1822) Patches for previously incompleted
patches
Posted by "Brian Whipple (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Whipple closed JCR-1822.
------------------------------
Resolution: Duplicate
This issues contained patches for two unapplied patches to the 1.4 branch. One was applied to the 1.5 trunk and is no longer necessary. I have opened up a new issue for the single ms-sqlserver tablespace patch in JCR-1924. This issue will be closed.
> Patches for previously incompleted patches
> ------------------------------------------
>
> Key: JCR-1822
> URL: https://issues.apache.org/jira/browse/JCR-1822
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core
> Affects Versions: core 1.4.6
> Reporter: Brian Whipple
> Attachments: jackrabbit-core.diff
>
>
> This is a patch to complete two earlier patches that were partially patched.
> JCR-1295 contained patch code for MS SqlServer tablespace support for the filesystem and db persistence manager that was not applied. I have cleaned up the submitted code and it should be applied to be consistent.
> JCR-1362 was a fix for Oracle schema test that was applied to 1.4 branch from trunk but was incomplete.
> This is a single patch for both issues.
> The fix for JCR-1362 only requires updating a single file from the patch: src/main/java/org/apache/jackrabbit/core/journal/DatabaseJournal.java
> All other files are related to completing JCR-1295.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.