You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ki...@apache.org on 2019/08/20 10:08:27 UTC

[commons-lang] branch master updated (92e7839 -> f0534ba)

This is an automated email from the ASF dual-hosted git repository.

kinow pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git.


    from 92e7839  Merge branch 'pr-427'
     new d20e4f5  [LANG-1476] Added sync for iterating over synced set
     new 2402e66  [LANG-1476] Add changes.xml entry
     new f0534ba  Merge branch 'pr-399'

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/changes/changes.xml                             | 1 +
 src/main/java/org/apache/commons/lang3/CharSet.java | 8 +++++---
 2 files changed, 6 insertions(+), 3 deletions(-)


[commons-lang] 02/03: [LANG-1476] Add changes.xml entry

Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

kinow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git

commit 2402e66a8c7e635540f7b9f6b39b83b5c812469d
Author: Bruno P. Kinoshita <ki...@apache.org>
AuthorDate: Tue Aug 20 22:04:05 2019 +1200

    [LANG-1476] Add changes.xml entry
---
 src/changes/changes.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 180cc9a..905a7b2 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -55,6 +55,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action issue="LANG-1470" type="add" dev="ggregory">Add ArrayUtils.addFirst() methods.</action>
     <action issue="LANG-1437" type="update" dev="ggregory" due-to="Andrei Troie">Remove redundant if statements in join methods #411.</action>
     <action issue="LANG-1460" type="fix" dev="kinow" due-to="Larry West">Trivial: year of release for 3.9 says 2018, should be 2019</action>
+    <action issue="LANG-1476" type="fix" dev="kinow" due-to="emopers">Use synchronise on a set created with Collections.synchronizedSet before iterating</action>
   </release>
 
   <release version="3.9" date="2019-04-09" description="New features and bug fixes. Requires Java 8, supports Java 9, 10, 11">


[commons-lang] 03/03: Merge branch 'pr-399'

Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

kinow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git

commit f0534ba8547ab5a9c64c4cecf0fa98fefa7ccc1d
Merge: 92e7839 2402e66
Author: Bruno P. Kinoshita <ki...@apache.org>
AuthorDate: Tue Aug 20 22:07:34 2019 +1200

    Merge branch 'pr-399'
    
    Closes #399

 src/changes/changes.xml                             | 1 +
 src/main/java/org/apache/commons/lang3/CharSet.java | 8 +++++---
 2 files changed, 6 insertions(+), 3 deletions(-)


[commons-lang] 01/03: [LANG-1476] Added sync for iterating over synced set

Posted by ki...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

kinow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git

commit d20e4f53af58315f2d7d79c235c90b3e76717607
Author: emopers <em...@gmail.com>
AuthorDate: Wed Jan 9 03:35:27 2019 -0600

    [LANG-1476] Added sync for iterating over synced set
---
 src/main/java/org/apache/commons/lang3/CharSet.java | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/lang3/CharSet.java b/src/main/java/org/apache/commons/lang3/CharSet.java
index 21e7e17..3fdfd07 100644
--- a/src/main/java/org/apache/commons/lang3/CharSet.java
+++ b/src/main/java/org/apache/commons/lang3/CharSet.java
@@ -237,9 +237,11 @@ public class CharSet implements Serializable {
      * @return {@code true} if the set contains the characters
      */
     public boolean contains(final char ch) {
-        for (final CharRange range : set) {
-            if (range.contains(ch)) {
-                return true;
+        synchronized(set) {
+            for (final CharRange range : set) {
+                if (range.contains(ch)) {
+                    return true;
+                }
             }
         }
         return false;